You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by vcharmcaster <gi...@git.apache.org> on 2016/06/25 04:55:49 UTC
[GitHub] cloudstack pull request #1597: added constant for magic code
GitHub user vcharmcaster opened a pull request:
https://github.com/apache/cloudstack/pull/1597
added constant for magic code
"=" was used in lots of space extracted it as constant
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vcharmcaster/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1597.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1597
----
commit bddeafbf4184d822b2b3968cd55dd1b74413cf7f
Author: Vaibhav kulkarni <vc...@users.noreply.github.com>
Date: 2016-06-25T04:55:07Z
added constant for magic code
"=" was used in lots of space extracted it as constant
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1597: added constant for magic code
Posted by vcharmcaster <gi...@git.apache.org>.
Github user vcharmcaster commented on the issue:
https://github.com/apache/cloudstack/pull/1597
@swill @syed updated formatting. Let me know if i missed something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1597: added constant for magic code
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1597
@vcharmcaster can you fix the space/tab issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1597: added constant for magic code
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1597
Packaging result: \u2716centos6 \u2716centos7 \u2716debian repo: http://packages.shapeblue.com/cloudstack/pr/1597
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1597: added constant for magic code
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1597
Should the result of the splits be stripped of whitespace to make sure there is no extra whitespace being saved into variables?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1597: added constant for magic code
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1597
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1597: added constant for magic code
Posted by syed <gi...@git.apache.org>.
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1597
Looks like there are some trailing space problems. Can you please fix that @vcharmcaster
```
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:25: error: Line has trailing spaces.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:26:1: error: Line contains a tab character.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:27: error: Line has trailing spaces.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:27:1: error: Line contains a tab character.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:28:1: error: Line contains a tab character.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:29: error: Line has trailing spaces.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:29:1: error: Line contains a tab character.
```
Also, can you rebase your commits into a single commit?
Otherwise, the code LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1597: added constant for magic code
Posted by syed <gi...@git.apache.org>.
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1597
@vcharmcaster it looks like your commit still did not fix the problems. Can you check the problems I mentioned in my previous comments. There are some trailing spaces and tabs which need to be fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1597: added constant for magic code
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1597
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1597: added constant for magic code
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1597
Packaging result: \u2716centos6 \u2716centos7 \u2716debian repo: http://packages.shapeblue.com/cloudstack/pr/1597
Job ID #66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1597: added constant for magic code
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1597
Packaging result: \u2716centos6 \u2716centos7 \u2716debian. JID-212
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1597: added constant for magic code
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1597
@rhtyd a Trillian-Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1597: added constant for magic code
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1597
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---