[jira] [Commented] (MSHARED-417) Infinite loop when loading self-referencing properties

["Gabriel Belingueres (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHARED-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409492#comment-15409492 ] 

Gabriel Belingueres commented on MSHARED-417:
---------------------------------------------

I could work on a patch to detect this kind of cycles on properties files.
Should the plugin throw an exception or continue with a logged warning?

> Infinite loop when loading self-referencing properties
> ------------------------------------------------------
>
>                 Key: MSHARED-417
>                 URL: https://issues.apache.org/jira/browse/MSHARED-417
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-filtering
>    Affects Versions: maven-filtering-1.3
>         Environment: Maven 3.2.5. Maven-filtering-1.3.
>            Reporter: Paul Milliken
>         Attachments: MSHARED-417.zip
>
>
> I've recently encountered a situation in which maven-resources-plugin would hang indefinitely when using resource filtering. I've managed to track it down to the loadPropertyFile and getPropertyValue methods in PropertyUtils.
> getPropertyValue appears to have some protection against a property referring to itself. So, the following properties file loads fine:
> {code}
> test=${test}
> test2=${test2}
> {code}
> With the value of the "test" property ending up as "$\{test\}". However, if you load the following properties file:
> {code}
> test=${test2}
> test2=${test2}
> {code}
> then getPropertyValue seems to get stuck in a loop attempting to resolve the property.
> In our case, this was encountered as a result of a misconfiguration (our filters.properties is being generated based on a number of sources, and something was configured incorrectly). Causing the Maven process to hang indefinitely (while using 100% of a CPU core) isn't ideal behaviour.
> I have reproduced this in isolation by directly invoking {{PropertyUtils.loadPropertyFile(File, null)}} with the the above data as the input file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)