You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/02 22:45:34 UTC
[GitHub] [tvm] spectrometerHBH opened a new pull request #9434: [TIR][Schedule] Add get-child-blocks primitive
spectrometerHBH opened a new pull request #9434:
URL: https://github.com/apache/tvm/pull/9434
cc @junrushao1994 @vinx13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9434: [TIR][Schedule] Add get-child-blocks primitive
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9434:
URL: https://github.com/apache/tvm/pull/9434#discussion_r743819492
##########
File path: src/tir/schedule/primitive.h
##########
@@ -63,6 +63,15 @@ Array<StmtSRef> GetBlocks(const ScheduleState& self, const String& name, const S
* \return A list of loops above the given block in its scope, from outer to inner
*/
Array<StmtSRef> GetLoops(const StmtSRef& block_sref);
+/*!
+ * \brief Get the leaf blocks of a specific block/loop
+ * \param self The schedule state
+ * \param parent_sref The query block/loop
+ * \param inclusive Whether to include parent_sref
+ * \return A list of leaf blocks inside a specific block/loop
+ */
+Array<StmtSRef> GetChildBlocks(const ScheduleState& self, const StmtSRef& parent_sref,
Review comment:
It's always false. I'm fine if we remove it or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy merged pull request #9434: [TIR][Schedule] Add get-child-blocks primitive
Posted by GitBox <gi...@apache.org>.
Hzfengsy merged pull request #9434:
URL: https://github.com/apache/tvm/pull/9434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9434: [TIR][Schedule] Add get-child-blocks primitive
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9434:
URL: https://github.com/apache/tvm/pull/9434#discussion_r743819492
##########
File path: src/tir/schedule/primitive.h
##########
@@ -63,6 +63,15 @@ Array<StmtSRef> GetBlocks(const ScheduleState& self, const String& name, const S
* \return A list of loops above the given block in its scope, from outer to inner
*/
Array<StmtSRef> GetLoops(const StmtSRef& block_sref);
+/*!
+ * \brief Get the leaf blocks of a specific block/loop
+ * \param self The schedule state
+ * \param parent_sref The query block/loop
+ * \param inclusive Whether to include parent_sref
+ * \return A list of leaf blocks inside a specific block/loop
+ */
+Array<StmtSRef> GetChildBlocks(const ScheduleState& self, const StmtSRef& parent_sref,
Review comment:
It's always false. I'm fine if we remove it or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on a change in pull request #9434: [TIR][Schedule] Add get-child-blocks primitive
Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on a change in pull request #9434:
URL: https://github.com/apache/tvm/pull/9434#discussion_r741716717
##########
File path: src/tir/schedule/primitive.h
##########
@@ -63,6 +63,15 @@ Array<StmtSRef> GetBlocks(const ScheduleState& self, const String& name, const S
* \return A list of loops above the given block in its scope, from outer to inner
*/
Array<StmtSRef> GetLoops(const StmtSRef& block_sref);
+/*!
+ * \brief Get the leaf blocks of a specific block/loop
+ * \param self The schedule state
+ * \param parent_sref The query block/loop
+ * \param inclusive Whether to include parent_sref
+ * \return A list of leaf blocks inside a specific block/loop
+ */
+Array<StmtSRef> GetChildBlocks(const ScheduleState& self, const StmtSRef& parent_sref,
Review comment:
Do we need the param`inclusive`? It seems always false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on a change in pull request #9434: [TIR][Schedule] Add get-child-blocks primitive
Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on a change in pull request #9434:
URL: https://github.com/apache/tvm/pull/9434#discussion_r741716717
##########
File path: src/tir/schedule/primitive.h
##########
@@ -63,6 +63,15 @@ Array<StmtSRef> GetBlocks(const ScheduleState& self, const String& name, const S
* \return A list of loops above the given block in its scope, from outer to inner
*/
Array<StmtSRef> GetLoops(const StmtSRef& block_sref);
+/*!
+ * \brief Get the leaf blocks of a specific block/loop
+ * \param self The schedule state
+ * \param parent_sref The query block/loop
+ * \param inclusive Whether to include parent_sref
+ * \return A list of leaf blocks inside a specific block/loop
+ */
+Array<StmtSRef> GetChildBlocks(const ScheduleState& self, const StmtSRef& parent_sref,
Review comment:
Do we need the param`inclusive`? It seems always false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9434: [TIR][Schedule] Add get-child-blocks primitive
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9434:
URL: https://github.com/apache/tvm/pull/9434#discussion_r743819492
##########
File path: src/tir/schedule/primitive.h
##########
@@ -63,6 +63,15 @@ Array<StmtSRef> GetBlocks(const ScheduleState& self, const String& name, const S
* \return A list of loops above the given block in its scope, from outer to inner
*/
Array<StmtSRef> GetLoops(const StmtSRef& block_sref);
+/*!
+ * \brief Get the leaf blocks of a specific block/loop
+ * \param self The schedule state
+ * \param parent_sref The query block/loop
+ * \param inclusive Whether to include parent_sref
+ * \return A list of leaf blocks inside a specific block/loop
+ */
+Array<StmtSRef> GetChildBlocks(const ScheduleState& self, const StmtSRef& parent_sref,
Review comment:
It's always false. I'm fine if we remove it or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on a change in pull request #9434: [TIR][Schedule] Add get-child-blocks primitive
Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on a change in pull request #9434:
URL: https://github.com/apache/tvm/pull/9434#discussion_r741716717
##########
File path: src/tir/schedule/primitive.h
##########
@@ -63,6 +63,15 @@ Array<StmtSRef> GetBlocks(const ScheduleState& self, const String& name, const S
* \return A list of loops above the given block in its scope, from outer to inner
*/
Array<StmtSRef> GetLoops(const StmtSRef& block_sref);
+/*!
+ * \brief Get the leaf blocks of a specific block/loop
+ * \param self The schedule state
+ * \param parent_sref The query block/loop
+ * \param inclusive Whether to include parent_sref
+ * \return A list of leaf blocks inside a specific block/loop
+ */
+Array<StmtSRef> GetChildBlocks(const ScheduleState& self, const StmtSRef& parent_sref,
Review comment:
Do we need the param`inclusive`? It seems always false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on a change in pull request #9434: [TIR][Schedule] Add get-child-blocks primitive
Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on a change in pull request #9434:
URL: https://github.com/apache/tvm/pull/9434#discussion_r741716717
##########
File path: src/tir/schedule/primitive.h
##########
@@ -63,6 +63,15 @@ Array<StmtSRef> GetBlocks(const ScheduleState& self, const String& name, const S
* \return A list of loops above the given block in its scope, from outer to inner
*/
Array<StmtSRef> GetLoops(const StmtSRef& block_sref);
+/*!
+ * \brief Get the leaf blocks of a specific block/loop
+ * \param self The schedule state
+ * \param parent_sref The query block/loop
+ * \param inclusive Whether to include parent_sref
+ * \return A list of leaf blocks inside a specific block/loop
+ */
+Array<StmtSRef> GetChildBlocks(const ScheduleState& self, const StmtSRef& parent_sref,
Review comment:
Do we need the param`inclusive`? It seems always false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org