You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@chukwa.apache.org by "Jie Huang (JIRA)" <ji...@apache.org> on 2012/07/16 11:25:33 UTC
[jira] [Created] (CHUKWA-649) To handle pid-file missing case while
stoping chukwa processes
Jie Huang created CHUKWA-649:
--------------------------------
Summary: To handle pid-file missing case while stoping chukwa processes
Key: CHUKWA-649
URL: https://issues.apache.org/jira/browse/CHUKWA-649
Project: Chukwa
Issue Type: Improvement
Components: Scripts
Affects Versions: 0.4.0, 0.6.0
Reporter: Jie Huang
Priority: Trivial
If the pid-file is missing accidentally, the stop script will print out usage prompt of "kill" command. It is quite confused for the end user. The simple fix is to check that pid-file before executing kill command.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CHUKWA-649) To handle pid-file missing case while
stoping chukwa processes
Posted by "Jie Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jie Huang updated CHUKWA-649:
-----------------------------
Attachment: Chukwa-649-0_4_v2.patch
Does it look better?
> To handle pid-file missing case while stoping chukwa processes
> --------------------------------------------------------------
>
> Key: CHUKWA-649
> URL: https://issues.apache.org/jira/browse/CHUKWA-649
> Project: Chukwa
> Issue Type: Improvement
> Components: Scripts
> Affects Versions: 0.4.0, 0.6.0
> Reporter: Jie Huang
> Priority: Trivial
> Attachments: Chukwa-649-0_4.patch, Chukwa-649-0_4_v2.patch
>
>
> If the pid-file is missing accidentally, the stop script will print out usage prompt of "kill" command. It is quite confused for the end user. The simple fix is to check that pid-file before executing kill command.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CHUKWA-649) To handle pid-file missing case
while stoping chukwa processes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420326#comment-13420326 ]
Hudson commented on CHUKWA-649:
-------------------------------
Integrated in Chukwa-trunk #454 (See [https://builds.apache.org/job/Chukwa-trunk/454/])
CHUKWA-649. Handle pid-file missing case while stoping chukwa processes. Contributed by Jie Huang. (Revision 1364418)
Result = SUCCESS
asrabkin : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1364418
Files :
* /incubator/chukwa/trunk/CHANGES.txt
* /incubator/chukwa/trunk/bin/chukwa
> To handle pid-file missing case while stoping chukwa processes
> --------------------------------------------------------------
>
> Key: CHUKWA-649
> URL: https://issues.apache.org/jira/browse/CHUKWA-649
> Project: Chukwa
> Issue Type: Improvement
> Components: Scripts
> Affects Versions: 0.4.0, 0.6.0
> Reporter: Jie Huang
> Priority: Trivial
> Attachments: Chukwa-649-0_4.patch, Chukwa-649-0_4_v2.patch, Chukwa-649-0_6.patch
>
>
> If the pid-file is missing accidentally, the stop script will print out usage prompt of "kill" command. It is quite confused for the end user. The simple fix is to check that pid-file before executing kill command.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CHUKWA-649) To handle pid-file missing case while
stoping chukwa processes
Posted by "Jie Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jie Huang updated CHUKWA-649:
-----------------------------
Attachment: Chukwa-649-0_4.patch
Simple fix. Or we can make it better. like adding some “if-else” clause with more prompts. If it is necessary, I will refine it. Any idea?
> To handle pid-file missing case while stoping chukwa processes
> --------------------------------------------------------------
>
> Key: CHUKWA-649
> URL: https://issues.apache.org/jira/browse/CHUKWA-649
> Project: Chukwa
> Issue Type: Improvement
> Components: Scripts
> Affects Versions: 0.4.0, 0.6.0
> Reporter: Jie Huang
> Priority: Trivial
> Attachments: Chukwa-649-0_4.patch
>
>
> If the pid-file is missing accidentally, the stop script will print out usage prompt of "kill" command. It is quite confused for the end user. The simple fix is to check that pid-file before executing kill command.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CHUKWA-649) To handle pid-file missing case
while stoping chukwa processes
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ari Rabkin resolved CHUKWA-649.
-------------------------------
Resolution: Fixed
I just committed this change to Trunk. Thanks, Jie.
Unless somebody tells me otherwise, I am assuming we have no intention to do a new 0.4 release; as a result, I think we don't need to produce or commit patches to that branch.
> To handle pid-file missing case while stoping chukwa processes
> --------------------------------------------------------------
>
> Key: CHUKWA-649
> URL: https://issues.apache.org/jira/browse/CHUKWA-649
> Project: Chukwa
> Issue Type: Improvement
> Components: Scripts
> Affects Versions: 0.4.0, 0.6.0
> Reporter: Jie Huang
> Priority: Trivial
> Attachments: Chukwa-649-0_4.patch, Chukwa-649-0_4_v2.patch, Chukwa-649-0_6.patch
>
>
> If the pid-file is missing accidentally, the stop script will print out usage prompt of "kill" command. It is quite confused for the end user. The simple fix is to check that pid-file before executing kill command.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CHUKWA-649) To handle pid-file missing case
while stoping chukwa processes
Posted by "Jie Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420407#comment-13420407 ]
Jie Huang commented on CHUKWA-649:
----------------------------------
Thanks. I will move all my patch work against the latest version now.
> To handle pid-file missing case while stoping chukwa processes
> --------------------------------------------------------------
>
> Key: CHUKWA-649
> URL: https://issues.apache.org/jira/browse/CHUKWA-649
> Project: Chukwa
> Issue Type: Improvement
> Components: Scripts
> Affects Versions: 0.4.0, 0.6.0
> Reporter: Jie Huang
> Priority: Trivial
> Attachments: Chukwa-649-0_4.patch, Chukwa-649-0_4_v2.patch, Chukwa-649-0_6.patch
>
>
> If the pid-file is missing accidentally, the stop script will print out usage prompt of "kill" command. It is quite confused for the end user. The simple fix is to check that pid-file before executing kill command.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CHUKWA-649) To handle pid-file missing case while
stoping chukwa processes
Posted by "Jie Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jie Huang updated CHUKWA-649:
-----------------------------
Attachment: Chukwa-649-0_6.patch
> To handle pid-file missing case while stoping chukwa processes
> --------------------------------------------------------------
>
> Key: CHUKWA-649
> URL: https://issues.apache.org/jira/browse/CHUKWA-649
> Project: Chukwa
> Issue Type: Improvement
> Components: Scripts
> Affects Versions: 0.4.0, 0.6.0
> Reporter: Jie Huang
> Priority: Trivial
> Attachments: Chukwa-649-0_4.patch, Chukwa-649-0_4_v2.patch, Chukwa-649-0_6.patch
>
>
> If the pid-file is missing accidentally, the stop script will print out usage prompt of "kill" command. It is quite confused for the end user. The simple fix is to check that pid-file before executing kill command.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CHUKWA-649) To handle pid-file missing case
while stoping chukwa processes
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416860#comment-13416860 ]
Ari Rabkin commented on CHUKWA-649:
-----------------------------------
I think it would be better to explicitly tell the user if there's nothing to kill.
Possible wording: "No PID file found; not killing. Perhaps Chukwa was not running?"
> To handle pid-file missing case while stoping chukwa processes
> --------------------------------------------------------------
>
> Key: CHUKWA-649
> URL: https://issues.apache.org/jira/browse/CHUKWA-649
> Project: Chukwa
> Issue Type: Improvement
> Components: Scripts
> Affects Versions: 0.4.0, 0.6.0
> Reporter: Jie Huang
> Priority: Trivial
> Attachments: Chukwa-649-0_4.patch
>
>
> If the pid-file is missing accidentally, the stop script will print out usage prompt of "kill" command. It is quite confused for the end user. The simple fix is to check that pid-file before executing kill command.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CHUKWA-649) To handle pid-file missing case
while stoping chukwa processes
Posted by "Jie Huang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CHUKWA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416864#comment-13416864 ]
Jie Huang commented on CHUKWA-649:
----------------------------------
Yes. I will update the patch accordingly.
> To handle pid-file missing case while stoping chukwa processes
> --------------------------------------------------------------
>
> Key: CHUKWA-649
> URL: https://issues.apache.org/jira/browse/CHUKWA-649
> Project: Chukwa
> Issue Type: Improvement
> Components: Scripts
> Affects Versions: 0.4.0, 0.6.0
> Reporter: Jie Huang
> Priority: Trivial
> Attachments: Chukwa-649-0_4.patch
>
>
> If the pid-file is missing accidentally, the stop script will print out usage prompt of "kill" command. It is quite confused for the end user. The simple fix is to check that pid-file before executing kill command.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira