You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/01 17:40:00 UTC
[jira] [Commented] (MINIFI-363) Set format macros before inclusion
of inttypes.h
[ https://issues.apache.org/jira/browse/MINIFI-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109381#comment-16109381 ]
ASF GitHub Bot commented on MINIFI-363:
---------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/123
MINIFI-363: Set format macro declaration to avoid issues from GLIBC
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-363
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #123
----
commit 7b7b1b5bc20a92243aebe7ebe0816963a88747a0
Author: Marc Parisi <ph...@apache.org>
Date: 2017-08-01T17:39:15Z
MINIFI-363: Set format macro declaration to avoid issues from GLIBC
----
> Set format macros before inclusion of inttypes.h
> ------------------------------------------------
>
> Key: MINIFI-363
> URL: https://issues.apache.org/jira/browse/MINIFI-363
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
>
> Set format macros before inclusion of inttypes.h
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)