[GitHub] [pulsar] lordcheng10 edited a comment on pull request #14970: [fix][broker] The offline consumer is not removed from the consumerList

[GitBox <gi...@apache.org>]

lordcheng10 edited a comment on pull request #14970:
URL: https://github.com/apache/pulsar/pull/14970#issuecomment-1084941600


   In fact, the problem here may be the problem of consumer equality, similar to the previous producer problem.
   
   When there are duplicate consumers in the consumerList, it is possible to remove the actually successfully registered consumers when removing them? 
   
   In fact, in our scenario, we also found a problem: when the consumer reconnects, although we can see that the number of consumers has not changed through monitoring, the broker no longer pushes messages to these consumers. Through the stats command, we see these The consumer's permit is 0, and it is a consumer that has been removed from the consumerSet and consumers.
   
   
   So the fundamental problem here is actually the definition of consumer equality. I think we might need to do something like https://github.com/apache/pulsar/pull/12846 on the definition of equality for consumers.
   
   I see concerns about the definition of consumer equality in this PR https://github.com/apache/pulsar/pull/12846, and in our scenario, it does seem to remove the wrong consumer.
   
   I think we also need to implement a method similar to isSuccessorTo to determine whether the consumer can be overridden, what do you think? @lhotari @michaeljmarshall @eolivelli 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org