You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/10 15:57:23 UTC

[GitHub] [flink] fapaul opened a new pull request #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name

fapaul opened a new pull request #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name
URL: https://github.com/apache/flink/pull/11371
 
 
   ## What is the purpose of the change
   
   Improve displayed name for TwoPhaseCommitSink subtask instances.
   
   ## Brief change log
   
   Increment the subtask index before displaying it to better match the parallelism which index starts at 1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on issue #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name

Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name
URL: https://github.com/apache/flink/pull/11371#issuecomment-597475949
 
 
   Travis is green, let's ignore the nit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name
URL: https://github.com/apache/flink/pull/11371#issuecomment-597166752
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit ad1024e8f4be765101b5e8f33f5755fd0ffe1e38 (Tue Mar 10 15:59:59 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16525).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski merged pull request #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name

Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name
URL: https://github.com/apache/flink/pull/11371
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name
URL: https://github.com/apache/flink/pull/11371#issuecomment-597179274
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ad1024e8f4be765101b5e8f33f5755fd0ffe1e38",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6141",
       "triggerID" : "ad1024e8f4be765101b5e8f33f5755fd0ffe1e38",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ad1024e8f4be765101b5e8f33f5755fd0ffe1e38",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/152667921",
       "triggerID" : "ad1024e8f4be765101b5e8f33f5755fd0ffe1e38",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ad1024e8f4be765101b5e8f33f5755fd0ffe1e38 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/152667921) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6141) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name
URL: https://github.com/apache/flink/pull/11371#issuecomment-597179274
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ad1024e8f4be765101b5e8f33f5755fd0ffe1e38",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6141",
       "triggerID" : "ad1024e8f4be765101b5e8f33f5755fd0ffe1e38",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ad1024e8f4be765101b5e8f33f5755fd0ffe1e38",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/152667921",
       "triggerID" : "ad1024e8f4be765101b5e8f33f5755fd0ffe1e38",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ad1024e8f4be765101b5e8f33f5755fd0ffe1e38 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/152667921) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6141) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11371: [FLINK-16525][task] Increment subtask id by 1 to display subtask name
URL: https://github.com/apache/flink/pull/11371#issuecomment-597179274
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ad1024e8f4be765101b5e8f33f5755fd0ffe1e38",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ad1024e8f4be765101b5e8f33f5755fd0ffe1e38",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ad1024e8f4be765101b5e8f33f5755fd0ffe1e38 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services