You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/03/09 05:19:13 UTC

[GitHub] [kafka] ableegoldman opened a new pull request #11867: KAFKA-12648: include IOException and topologyName in the wrapping StreamsException when clearing named topology state fails

ableegoldman opened a new pull request #11867:
URL: https://github.com/apache/kafka/pull/11867


   Quick fix to make sure we log the actual source of the failure both in the actual log message as well as the StreamsException that we bubble up to the user's exception handler, and also to report the offending topology by filling in the StreamsException's `taskId` field


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #11867: KAFKA-12648: fix #getMinThreadVersion and include IOException + topologyName in StreamsException when topology dir cleanup fails

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11867:
URL: https://github.com/apache/kafka/pull/11867#issuecomment-1062571710


   Hey @wcarlson5 @guozhangwang @vvcephei @showuon can I get a very quick review for this ~10 line fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #11867: KAFKA-12648: fix #getMinThreadVersion and include IOException + topologyName in StreamsException when topology dir cleanup fails

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11867:
URL: https://github.com/apache/kafka/pull/11867#issuecomment-1063520314


   Found a somewhat more involved bug that was responsible for this test failing, so I opened a second bugfix PR you can find here
   
   Without this followup PR, the test may continue to see failures (as we see in the build results here). 
   
   But otherwise test failures are unrelated, going to merge this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman merged pull request #11867: KAFKA-12648: fix #getMinThreadVersion and include IOException + topologyName in StreamsException when topology dir cleanup fails

Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11867:
URL: https://github.com/apache/kafka/pull/11867


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #11867: KAFKA-12648: fix #getMinThreadVersion and include IOException + topologyName in StreamsException when topology dir cleanup fails

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11867:
URL: https://github.com/apache/kafka/pull/11867#issuecomment-1063520672


   Merged to trunk


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org