You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/16 05:35:51 UTC

[GitHub] [flink] zhijiangW opened a new pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

zhijiangW opened a new pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes
URL: https://github.com/apache/flink/pull/8181
 
 
   ## What is the purpose of the change
   
   *At the moment we have `numBytesInLocal/numBytesInRemote` in `IOMetrics` but in the actual usage we just always sum them up. As local/remote is the detail of shuffle service implementation, we can merge the local/remote metrics into one and increment it later in `Task` instead of remote/local channels in network internals.*
   
   ## Brief change log
   
     - *Remove legacy metric related codes*
     - *Merge local/remote related metrics into one*
     - *Modify `LocalInputChannel` and `RemoteInputChannel` to reference with the same metric*
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services