You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/06 21:15:22 UTC

[GitHub] [beam] lostluck commented on issue #11325: [BEAM-4374, BEAM-6189] Delete and remove deprecated Metrics proto

lostluck commented on issue #11325: [BEAM-4374, BEAM-6189] Delete and remove deprecated Metrics proto
URL: https://github.com/apache/beam/pull/11325#issuecomment-610040706
 
 
   LGTM for Go
   Note, any errors in this won't be caught by the Go precommit, but given the Go postcommit is still grumpy there's no open verification of this at this time. (Granted this isn't automated in any of the Go SDK tests at this time, as the SDK has no user side metric extraction API just yet.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services