You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Alexander Aghili (Jira)" <ji...@apache.org> on 2023/12/23 02:10:00 UTC

[jira] [Comment Edited] (KAFKA-16027) Refactor MetadataTest#testUpdatePartitionLeadership

    [ https://issues.apache.org/jira/browse/KAFKA-16027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799209#comment-17799209 ] 

Alexander Aghili edited comment on KAFKA-16027 at 12/23/23 2:09 AM:
--------------------------------------------------------------------

Made a pull request for refactoring.
Didn't move it to ConsumerMetadata.java due to some additional complications. 
Discussions can take place on the PR.


was (Author: JIRAUSER303109):
[https://github.com/apache/kafka/pull/15055]
Made a pull request for refactoring.
Didn't move it to ConsumerMetadata.java due to some additional complications. 
Discussions can take place on the PR.

> Refactor MetadataTest#testUpdatePartitionLeadership
> ---------------------------------------------------
>
>                 Key: KAFKA-16027
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16027
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Philip Nee
>            Assignee: Alexander Aghili
>            Priority: Minor
>              Labels: newbie
>
> MetadataTest#testUpdatePartitionLeadership is extremely long.  I think it is pretty close to the 160 line method limit - I tried to modfity it but it would hit the limit when i tried to break things into separated lines.
> The test also contains two tests, so it is best to split it into two separate tests.
> We should also move this to ConsumerMetadata.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)