You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Jason Dere <jd...@hortonworks.com> on 2014/03/20 03:42:52 UTC

Review Request 19447: HIVE-6704: date_add()/date_sub()/datediff() fail with NPE with null input

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19447/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-6704
    https://issues.apache.org/jira/browse/HIVE-6704


Repository: hive-git


Description
-------

Return null if input args are null.
Also support char/varchar args.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java 1b6c64d 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java 92b1000 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java 125e467 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateAdd.java ee841d3 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateDiff.java 936c554 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateSub.java 46153e0 

Diff: https://reviews.apache.org/r/19447/diff/


Testing
-------


Thanks,

Jason Dere