You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/02 13:30:00 UTC

[GitHub] angelcervera commented on a change in pull request #2953: [WiP] ElasticSearch connector integration

angelcervera commented on a change in pull request #2953: [WiP] ElasticSearch connector integration
URL: https://github.com/apache/incubator-superset/pull/2953#discussion_r165644190
 
 

 ##########
 File path: superset/config.py
 ##########
 @@ -190,6 +190,7 @@
 DEFAULT_MODULE_DS_MAP = OrderedDict([
     ('superset.connectors.sqla.models', ['SqlaTable']),
     ('superset.connectors.druid.models', ['DruidDatasource']),
+    ('superset.connectors.elastic.models', ['ElasticDatasource']),
 
 Review comment:
   Maybe is good don't short the name and call it `.elasticsearch.` and `ElasticseachDatasource` to avoid confusion with other future datasources.
   I don't know at the moment, but maybe in the future people wants integration with other products, for example, _Elastic Query_ from Azure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services