You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (JIRA)" <ji...@apache.org> on 2010/08/30 21:01:00 UTC
[jira] Created: (CASSANDRA-1443) shell scripts are not posix
compliant
shell scripts are not posix compliant
-------------------------------------
Key: CASSANDRA-1443
URL: https://issues.apache.org/jira/browse/CASSANDRA-1443
Project: Cassandra
Issue Type: Bug
Affects Versions: 0.6
Reporter: Brandon Williams
Assignee: Eric Evans
Priority: Minor
Fix For: 0.6.6
Our shells scripts currently require bash, but invoke /bin/sh which may or may not be bash. Instead, we should make these scripts POSIX compliant so they work under any shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1443) shell scripts are not posix
compliant
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909831#action_12909831 ]
Brandon Williams commented on CASSANDRA-1443:
---------------------------------------------
I would gladly accept patches for that. I wasn't aware we had any linuxisms in there.
> shell scripts are not posix compliant
> -------------------------------------
>
> Key: CASSANDRA-1443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1443
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.6
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Minor
> Fix For: 0.6.6
>
> Attachments: 1443.txt
>
>
> Our shells scripts currently require bash, but invoke /bin/sh which may or may not be bash. Instead, we should make these scripts POSIX compliant so they work under any shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1443) shell scripts are not posix
compliant
Posted by "Peter Schuller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909829#action_12909829 ]
Peter Schuller commented on CASSANDRA-1443:
-------------------------------------------
There are also a couple of Linux specific things in there. Since I'm on FreeBSD I hit them. Would you be open to patches that try to work around that, or is that beyond reasonable portability goals?
> shell scripts are not posix compliant
> -------------------------------------
>
> Key: CASSANDRA-1443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1443
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.6
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Minor
> Fix For: 0.6.6
>
> Attachments: 1443.txt
>
>
> Our shells scripts currently require bash, but invoke /bin/sh which may or may not be bash. Instead, we should make these scripts POSIX compliant so they work under any shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1443) shell scripts are not posix
compliant
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-1443:
----------------------------------------
Attachment: 1443.txt
After trying to make the scripts work under multiple shells, I think the best compromise here is just just invoke bash directly. It won't stop people from shooting themselves in the foot by invoking some other shell (`sh bin/cassandra`) but that is hopefully a rare case. Trying to make all of our scripts work under csh is especially problematic and would require changing a lot of logic in the scripts.
> shell scripts are not posix compliant
> -------------------------------------
>
> Key: CASSANDRA-1443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1443
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.6
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Minor
> Fix For: 0.6.6
>
> Attachments: 1443.txt
>
>
> Our shells scripts currently require bash, but invoke /bin/sh which may or may not be bash. Instead, we should make these scripts POSIX compliant so they work under any shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1443) shell scripts are not posix
compliant
Posted by "Peter Schuller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910033#action_12910033 ]
Peter Schuller commented on CASSANDRA-1443:
-------------------------------------------
Sorry - no, nothing to add. 1507/1508 was the ones I knew of off hand. Should I discover anything else I'll submit more.
(Though on the /bin/bash issue of this ticket I'd preemptively suggest using /usr/bin/env bash, since bash is often not /bin/bash on many BSD:s.)
> shell scripts are not posix compliant
> -------------------------------------
>
> Key: CASSANDRA-1443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1443
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.6
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Minor
> Fix For: 0.6.6
>
> Attachments: 1443.txt
>
>
> Our shells scripts currently require bash, but invoke /bin/sh which may or may not be bash. Instead, we should make these scripts POSIX compliant so they work under any shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1443) shell scripts are not posix
compliant
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909945#action_12909945 ]
Brandon Williams commented on CASSANDRA-1443:
---------------------------------------------
Peter, were the changes you were referring to in CASSANDRA-1507 or do you have more to add here?
> shell scripts are not posix compliant
> -------------------------------------
>
> Key: CASSANDRA-1443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1443
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.6
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Minor
> Fix For: 0.6.6
>
> Attachments: 1443.txt
>
>
> Our shells scripts currently require bash, but invoke /bin/sh which may or may not be bash. Instead, we should make these scripts POSIX compliant so they work under any shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-1443) shell scripts are not posix
compliant
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams reassigned CASSANDRA-1443:
-------------------------------------------
Assignee: Brandon Williams (was: Eric Evans)
> shell scripts are not posix compliant
> -------------------------------------
>
> Key: CASSANDRA-1443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1443
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.6
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Minor
> Fix For: 0.6.6
>
>
> Our shells scripts currently require bash, but invoke /bin/sh which may or may not be bash. Instead, we should make these scripts POSIX compliant so they work under any shell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.