You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "edmondop (via GitHub)" <gi...@apache.org> on 2024/06/04 02:45:40 UTC

[I] Support join filter in NestedLoopJoin in fizz join test cases [datafusion]

edmondop opened a new issue, #10787:
URL: https://github.com/apache/datafusion/issues/10787

   ### Is your feature request related to a problem or challenge?
   
   https://github.com/apache/datafusion/pull/10728 closes the first part of #10659, however combining the `on_filter` with the provided `join_filter` produces wrong results, 
   
   ```
   ---- fuzz_cases::join_fuzz::test_inner_join_1k_filtered stdout ----
   thread 'fuzz_cases::join_fuzz::test_inner_join_1k_filtered' panicked at datafusion\core\tests\fuzz_cases\join_fuzz.rs:387:17:
   assertion `left == right` failed: NestedLoopJoinExec and HashJoinExec produced different results
     left: (3, "| 21 | 21 | 2078626761  | 1773284061  | 21 | 25 | 1533589294  | 685853846   |")
    right: (3, "| 0  | 75 | -1848255860 | 30924674    | 0  | 75 | 1261908710  | 1064557805  |")
   stack backtrace:
   ```
   
   
   
   ### Describe the solution you'd like
   
   Add the right logic to the nested inner join loop filter
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Support join filter in NestedLoopJoin in fizz join test cases [datafusion]

Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on issue #10787:
URL: https://github.com/apache/datafusion/issues/10787#issuecomment-2151145063

   Thats interesting, I'll try to add a test case for it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org