TestCliDriver should log elapsed time
-------------------------------------
Key: HIVE-2760
URL: https://issues.apache.org/jira/browse/HIVE-2760
Project: Hive
Issue Type: Improvement
Components: Testing Infrastructure
Reporter: Carl Steinbach
Assignee: Carl Steinbach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/HIVE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2760:
---------------------------------
Status: Patch Available (was: Open)
> TestCliDriver should log elapsed time
> -------------------------------------
>
> Key: HIVE-2760
> URL: https://issues.apache.org/jira/browse/HIVE-2760
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-2760.D1503.1.patch, HIVE-2760.D1503.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/HIVE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2760:
------------------------------
Attachment: HIVE-2760.D1503.2.patch
cwsteinbach updated the revision "HIVE-2760 [jira] TestCliDriver should log elapsed time".
Reviewers: JIRA, ashutoshc
Adding changes requested by Ashutosh
REVISION DETAIL
https://reviews.facebook.net/D1503
AFFECTED FILES
hbase-handler/src/test/templates/TestHBaseCliDriver.vm
ql/src/test/templates/TestCliDriver.vm
ql/src/test/templates/TestNegativeCliDriver.vm
ql/src/test/templates/TestParse.vm
ql/src/test/templates/TestParseNegative.vm
> TestCliDriver should log elapsed time
> -------------------------------------
>
> Key: HIVE-2760
> URL: https://issues.apache.org/jira/browse/HIVE-2760
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-2760.D1503.1.patch, HIVE-2760.D1503.1.patch, HIVE-2760.D1503.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/HIVE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195249#comment-13195249 ]
Phabricator commented on HIVE-2760:
-----------------------------------
ashutoshc has commented on the revision "HIVE-2760 [jira] TestCliDriver should log elapsed time".
I think it will be useful for other test drivers as well.
TestHBaseCliDriver
TestNegativeCliDriver
TestParseNegative
TestParse
REVISION DETAIL
https://reviews.facebook.net/D1503
> TestCliDriver should log elapsed time
> -------------------------------------
>
> Key: HIVE-2760
> URL: https://issues.apache.org/jira/browse/HIVE-2760
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-2760.D1503.1.patch, HIVE-2760.D1503.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/HIVE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2760:
------------------------------
Attachment: HIVE-2760.D1503.1.patch
cwsteinbach requested code review of "HIVE-2760 [jira] TestCliDriver should log elapsed time".
Reviewers: JIRA
HIVE-2760. TestCliDriver should log elapsed time
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1503
AFFECTED FILES
ql/src/test/templates/TestCliDriver.vm
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/3117/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> TestCliDriver should log elapsed time
> -------------------------------------
>
> Key: HIVE-2760
> URL: https://issues.apache.org/jira/browse/HIVE-2760
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-2760.D1503.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/HIVE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195280#comment-13195280 ]
Phabricator commented on HIVE-2760:
-----------------------------------
ashutoshc has commented on the revision "HIVE-2760 [jira] TestCliDriver should log elapsed time".
Given that TestMinimrCliDriver has few queries which takes a long time, we should definitely time that. Sorry, I missed it previously and while we are at it, lets be comprehensive to get all of them timed. I guess following are the remaining ones
TestHBaseMinimrCliDriver
TestContribCliDriver
TestContribNegativeCliDriver
TestMinimrCliDriver
TestNegativeMinimrCliDriver
TestExecDriver
TestJdbcDriver
REVISION DETAIL
https://reviews.facebook.net/D1503
> TestCliDriver should log elapsed time
> -------------------------------------
>
> Key: HIVE-2760
> URL: https://issues.apache.org/jira/browse/HIVE-2760
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-2760.D1503.1.patch, HIVE-2760.D1503.1.patch, HIVE-2760.D1503.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/HIVE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2760:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.9.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk.
> TestCliDriver should log elapsed time
> -------------------------------------
>
> Key: HIVE-2760
> URL: https://issues.apache.org/jira/browse/HIVE-2760
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.9.0
>
> Attachments: HIVE-2760.D1503.1.patch, HIVE-2760.D1503.1.patch, HIVE-2760.D1503.2.patch, HIVE-2760.D1503.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/HIVE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195944#comment-13195944 ]
Hudson commented on HIVE-2760:
------------------------------
Integrated in Hive-trunk-h0.21 #1230 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1230/])
HIVE-2760 [jira] TestCliDriver should log elapsed time
Summary: HIVE-2760. TestCliDriver should log elapsed time
Test Plan: EMPTY
Reviewers: JIRA, ashutoshc
Reviewed By: ashutoshc
CC: ashutoshc, cwsteinbach
Differential Revision: https://reviews.facebook.net/D1503
cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1237511
Files :
* /hive/trunk/hbase-handler/src/test/templates/TestHBaseCliDriver.vm
* /hive/trunk/ql/src/test/templates/TestCliDriver.vm
* /hive/trunk/ql/src/test/templates/TestNegativeCliDriver.vm
* /hive/trunk/ql/src/test/templates/TestParse.vm
* /hive/trunk/ql/src/test/templates/TestParseNegative.vm
> TestCliDriver should log elapsed time
> -------------------------------------
>
> Key: HIVE-2760
> URL: https://issues.apache.org/jira/browse/HIVE-2760
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.9.0
>
> Attachments: HIVE-2760.D1503.1.patch, HIVE-2760.D1503.1.patch, HIVE-2760.D1503.2.patch, HIVE-2760.D1503.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/HIVE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195332#comment-13195332 ]
Phabricator commented on HIVE-2760:
-----------------------------------
cwsteinbach has commented on the revision "HIVE-2760 [jira] TestCliDriver should log elapsed time".
TestMinimrCliDriver is actually generated from TestCliDriver.vm. The same thing goes for the other tests you flagged. Take a look at the qtestgen task in the various build.xml for more info.
REVISION DETAIL
https://reviews.facebook.net/D1503
> TestCliDriver should log elapsed time
> -------------------------------------
>
> Key: HIVE-2760
> URL: https://issues.apache.org/jira/browse/HIVE-2760
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-2760.D1503.1.patch, HIVE-2760.D1503.1.patch, HIVE-2760.D1503.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/HIVE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195168#comment-13195168 ]
Carl Steinbach commented on HIVE-2760:
--------------------------------------
It would be nice if TestCliDriver logged the elapsed time of each testcase to stdout, e.g:
{noformat}
[junit] Begin query: alter2.q
[junit] diff -a /Users/carl/Work/repos/hive2/build/ql/test/logs/clientpositive/alter2.q.out /Users/carl/Work/repos/hive2/ql/src/test/results/clientpositive/alter2.q.out
[junit] Done query: alter2.q elapsedTime=5s
{noformat}
> TestCliDriver should log elapsed time
> -------------------------------------
>
> Key: HIVE-2760
> URL: https://issues.apache.org/jira/browse/HIVE-2760
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/HIVE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209156#comment-13209156 ]
Phabricator commented on HIVE-2760:
-----------------------------------
cwsteinbach has committed the revision "HIVE-2760 [jira] TestCliDriver should log elapsed time".
Change committed by cws.
REVISION DETAIL
https://reviews.facebook.net/D1503
COMMIT
https://reviews.facebook.net/rHIVE1237511
> TestCliDriver should log elapsed time
> -------------------------------------
>
> Key: HIVE-2760
> URL: https://issues.apache.org/jira/browse/HIVE-2760
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.9.0
>
> Attachments: HIVE-2760.D1503.1.patch, HIVE-2760.D1503.1.patch, HIVE-2760.D1503.2.patch, HIVE-2760.D1503.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/HIVE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195653#comment-13195653 ]
Phabricator commented on HIVE-2760:
-----------------------------------
ashutoshc has accepted the revision "HIVE-2760 [jira] TestCliDriver should log elapsed time".
Correct. +1
REVISION DETAIL
https://reviews.facebook.net/D1503
> TestCliDriver should log elapsed time
> -------------------------------------
>
> Key: HIVE-2760
> URL: https://issues.apache.org/jira/browse/HIVE-2760
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-2760.D1503.1.patch, HIVE-2760.D1503.1.patch, HIVE-2760.D1503.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/HIVE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2760:
---------------------------------
Attachment: HIVE-2760.D1503.2.patch
> TestCliDriver should log elapsed time
> -------------------------------------
>
> Key: HIVE-2760
> URL: https://issues.apache.org/jira/browse/HIVE-2760
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.9.0
>
> Attachments: HIVE-2760.D1503.1.patch, HIVE-2760.D1503.1.patch, HIVE-2760.D1503.2.patch, HIVE-2760.D1503.2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/HIVE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2760:
---------------------------------
Attachment: HIVE-2760.D1503.1.patch
> TestCliDriver should log elapsed time
> -------------------------------------
>
> Key: HIVE-2760
> URL: https://issues.apache.org/jira/browse/HIVE-2760
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-2760.D1503.1.patch, HIVE-2760.D1503.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira