You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by physikerwelt <gi...@git.apache.org> on 2014/09/08 22:37:59 UTC
[GitHub] incubator-flink pull request: Remove naive verification of tuple s...
GitHub user physikerwelt opened a pull request:
https://github.com/apache/incubator-flink/pull/116
Remove naive verification of tuple size
This verification will not work.
Think of spaces or escaped ?
I think it's easier for users to parse the SQLException
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/physikerwelt/incubator-flink patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit b51b4f019ad834c3525481c5fd5440d0f362e462
Author: Moritz Schubotz <gi...@ckurs.de>
Date: 2014-09-08T20:37:53Z
Remove naive verification of tuple size
This verification will not work.
Think of spaces or escaped ?
I think it's easier for users to parse the SQLException
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Remove naive verification of tuple s...
Posted by physikerwelt <gi...@git.apache.org>.
Github user physikerwelt commented on the pull request:
https://github.com/apache/incubator-flink/pull/116#issuecomment-54889111
... oh I did not realize that there is a tests concerning this feature...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Remove naive verification of tuple s...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/116#issuecomment-54899708
I think its not your fault that the test failed there. Our tests are using a lot of memory and most likely the kernel of the travis worker killed the jvm (oom killer).
I think your changes are passing the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Remove naive verification of tuple s...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/116#issuecomment-54886421
That seems reasonable.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Remove naive verification of tuple s...
Posted by physikerwelt <gi...@git.apache.org>.
Github user physikerwelt commented on the pull request:
https://github.com/apache/incubator-flink/pull/116#issuecomment-54898739
@rmetzger can you check why the second build fails?
I can not see any connection from the error message
```
/home/travis/build.sh: line 41: 1551 Killed mvn -Dflink.forkCount=4 -B $PROFILE clean install verify
The command "mvn -Dflink.forkCount=4 -B $PROFILE clean install verify" exited with 137.
```
to my change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Remove naive verification of tuple s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-flink/pull/116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---