You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by oh...@apache.org on 2015/05/10 22:12:14 UTC
svn commit: r1678611 - in /commons/proper/configuration/trunk/conf:
checkstyle-suppressions.xml checkstyle.xml
Author: oheger
Date: Sun May 10 20:12:13 2015
New Revision: 1678611
URL: http://svn.apache.org/r1678611
Log:
Removed checkstyle check for double checked locking.
The check seems to be outdated as this idiom works correctly with volatile
fields. The check for inner assignments was removed as well; inner assignments
are necessary to implement this idiom in the most efficient way.
Modified:
commons/proper/configuration/trunk/conf/checkstyle-suppressions.xml
commons/proper/configuration/trunk/conf/checkstyle.xml
Modified: commons/proper/configuration/trunk/conf/checkstyle-suppressions.xml
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/conf/checkstyle-suppressions.xml?rev=1678611&r1=1678610&r2=1678611&view=diff
==============================================================================
--- commons/proper/configuration/trunk/conf/checkstyle-suppressions.xml (original)
+++ commons/proper/configuration/trunk/conf/checkstyle-suppressions.xml Sun May 10 20:12:13 2015
@@ -28,9 +28,6 @@
<suppress checks="MissingSwitchDefault" files="PropertiesConfiguration.java"/>
- <suppress checks="DoubleCheckedLocking" files="DynamicCombinedConfiguration.java"
- lines="800-900"/>
-
<!-- There is an empty catch block ignoring unsupported operation exceptions
from the list delimiter handler. This is okay, then the property is
written out in multiple lines.
Modified: commons/proper/configuration/trunk/conf/checkstyle.xml
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/conf/checkstyle.xml?rev=1678611&r1=1678610&r2=1678611&view=diff
==============================================================================
--- commons/proper/configuration/trunk/conf/checkstyle.xml (original)
+++ commons/proper/configuration/trunk/conf/checkstyle.xml Sun May 10 20:12:13 2015
@@ -143,10 +143,8 @@
<!-- Checks for common coding problems -->
<!-- See http://checkstyle.sf.net/config_coding.html -->
<module name="CovariantEquals"/>
- <module name="DoubleCheckedLocking"/>
<module name="EqualsHashCode"/>
<module name="IllegalInstantiation"/>
- <module name="InnerAssignment"/>
<module name="MagicNumber">
<property name="ignoreNumbers" value="-1,0,1,2,3"/>
</module>