You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2014/11/12 09:23:16 UTC

Re: git commit: PropertyResourceModel as alternative to StringResourceModel

Hi Sven,

Are you going to add this class to 6.x/7.x ?

Please also take a look at the improvement I've added with
https://issues.apache.org/jira/browse/WICKET-5754

On Fri, Sep 26, 2014 at 5:10 PM, Andrea Del Bene <an...@gmail.com>
wrote:

> Got it! Thank you!
>
>  Hi Andrea,
>>
>> >I think we could remove single model parameter from constructors to make
>> PropertyResourceModel lighter
>>
>> then you'd have to prefix each property expression, even when only one
>> model is used:
>>
>>     new PropertyResourceModel("key", this, MiniMap.of("foo", fooModel));
>>
>>     key=This is message ${foo.bar}.
>>
>> I'd prefer to keep this case simpler for the user (as it is with
>> StringResourceModel):
>>
>>     new PropertyResourceModel("key", this, fooModel);
>>
>>     key=This is message ${bar}.
>>
>> Have fun
>> Sven
>>
>
>

Re: git commit: PropertyResourceModel as alternative to StringResourceModel

Posted by Sven Meier <sv...@meiers.net>.

Hi Martin,

I'll add PropertyResourceModel to 7.x only: To prevent duplication of 
functionality I want to deprecate StringResourceModel, this should not 
be done in 6.x.

 > improvement I've added with 
https://issues.apache.org/jira/browse/WICKET-5754

Thanks, I will do.

Regards
Sven


On 11/12/2014 09:23 AM, Martin Grigorov wrote:
> Hi Sven,
>
> Are you going to add this class to 6.x/7.x ?
>
> Please also take a look at the improvement I've added with
> https://issues.apache.org/jira/browse/WICKET-5754
>
> On Fri, Sep 26, 2014 at 5:10 PM, Andrea Del Bene <an...@gmail.com>
> wrote:
>
>> Got it! Thank you!
>>
>>   Hi Andrea,
>>>> I think we could remove single model parameter from constructors to make
>>> PropertyResourceModel lighter
>>>
>>> then you'd have to prefix each property expression, even when only one
>>> model is used:
>>>
>>>      new PropertyResourceModel("key", this, MiniMap.of("foo", fooModel));
>>>
>>>      key=This is message ${foo.bar}.
>>>
>>> I'd prefer to keep this case simpler for the user (as it is with
>>> StringResourceModel):
>>>
>>>      new PropertyResourceModel("key", this, fooModel);
>>>
>>>      key=This is message ${bar}.
>>>
>>> Have fun
>>> Sven
>>>
>>