[GitHub] spark pull request #16246: [SPARK-18814][SQL] CheckAnalysis rejects TPCDS qu...

[dilipbiswal <gi...@git.apache.org>]

Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16246#discussion_r101618460
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ---
    @@ -136,24 +140,35 @@ trait CheckAnalysis extends PredicateHelper {
                     failAnalysis("The output of a correlated scalar subquery must be aggregated")
                   }
     
    -              // SPARK-18504: block cases where GROUP BY columns
    -              // are not part of the correlated columns
    -              val groupByCols = ExpressionSet.apply(agg.groupingExpressions.flatMap(_.references))
    -              val predicateCols = ExpressionSet.apply(conditions.flatMap(_.references))
    -              val invalidCols = groupByCols.diff(predicateCols)
    +              // SPARK-18504/SPARK-18814: Block cases where GROUP BY columns
    +              // are not part of the correlated columns.
    +              val groupByCols = AttributeSet(agg.groupingExpressions.flatMap(_.references))
    +              val correlatedCols = AttributeSet(subqueryColumns)
    +              val invalidCols = groupByCols -- correlatedCols
                   // GROUP BY columns must be a subset of columns in the predicates
                   if (invalidCols.nonEmpty) {
                     failAnalysis(
    -                  "a GROUP BY clause in a scalar correlated subquery " +
    +                  "A GROUP BY clause in a scalar correlated subquery " +
                         "cannot contain non-correlated columns: " +
                         invalidCols.mkString(","))
                   }
                 }
     
    -            // Skip projects and subquery aliases added by the Analyzer and the SQLBuilder.
    +            // Skip subquery aliases added by the Analyzer and the SQLBuilder.
    +            // For projects, do the necessary mapping and skip to its child.
                 def cleanQuery(p: LogicalPlan): LogicalPlan = p match {
                   case s: SubqueryAlias => cleanQuery(s.child)
    -              case p: Project => cleanQuery(p.child)
    +              case p: Project =>
    --- End diff --
    
    Now the de-duplication of sub plan happens in optimizer when we actually pull up the correlated predicates. Therefore the following code block is simplified.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org