You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by dkhwangbo <gi...@git.apache.org> on 2015/10/05 11:21:52 UTC
[GitHub] tajo pull request: TAJO-1909: Eliminate remained explicit diamond ...
GitHub user dkhwangbo opened a pull request:
https://github.com/apache/tajo/pull/802
TAJO-1909: Eliminate remained explicit diamond expressions
I found some remain part after working TAJO-1844.
This is another work of remove it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dkhwangbo/tajo TAJO-1909
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/802.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #802
----
commit dd642a78646ed99e038ee08b0dd063c072bf4aa3
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date: 2015-10-05T09:19:22Z
initial commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1909: Eliminate remained explicit diamond ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/802
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1909: Eliminate remained explicit diamond ...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/802#issuecomment-146088935
@hyunsik Thanks for your reply. I rebase it. Please review again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1909: Eliminate remained explicit diamond ...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/802#issuecomment-145775013
Travis-ci gives me the error message but This commit pass the same test in my local environment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1909: Eliminate remained explicit diamond ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/802#issuecomment-146077889
That's not your fault. I'll manually verify the patch and review it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1909: Eliminate remained explicit diamond ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/802#issuecomment-146078424
Could you rebase the patch? The patch causes the following error:
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project tajo-common: Compilation failure
[ERROR] /home/hyunsik/Code/tajo/tajo/tajo-common/src/main/java/org/apache/tajo/util/ShutdownHookManager.java:[103,34] incompatible types: java.util.Set<java.lang.Object> cannot be converted to java.util.Set<org.apache.tajo.util.ShutdownHookManager.HookEntry>
```
#778 changes the source and target JVM of tajo-common to 1.7. It may cause this problem, I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---