You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by "Nick Couchman (JIRA)" <ji...@apache.org> on 2017/09/27 17:27:00 UTC

[jira] [Updated] (GUACAMOLE-398) Memory Leak in SSH COdo

     [ https://issues.apache.org/jira/browse/GUACAMOLE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Couchman updated GUACAMOLE-398:
------------------------------------
    Summary: Memory Leak in SSH COdo  (was: Memory Leak in SSH COde)

> Memory Leak in SSH COdo
> -----------------------
>
>                 Key: GUACAMOLE-398
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-398
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole-server
>    Affects Versions: 0.9.13-incubating
>            Reporter: Nick Couchman
>            Assignee: Nick Couchman
>            Priority: Minor
>
> Coverity identified a memory leak in some recently-changed SSH code in the Guacamole server component.
> *** CID 1311788:  Resource leaks  (RESOURCE_LEAK)
> /src/common-ssh/ssh.c: 460 in guac_common_ssh_create_session()
> 454    
> 455            /* Get socket */
> 456            fd = socket(current_address->ai_family, SOCK_STREAM, 0);
> 457            if (fd < 0) {
> 458                guac_client_abort(client, GUAC_PROTOCOL_STATUS_SERVER_ERROR,
> 459                        "Unable to create socket: %s", strerror(errno));
> >>>    CID 1311788:  Resource leaks  (RESOURCE_LEAK)
> >>>    Variable "addresses" going out of scope leaks the storage it points to.
> 460                return NULL;
> 461            }
> 462    
> 463            /* Connect */
> 464            if (connect(fd, current_address->ai_addr,
> 465                            current_address->ai_addrlen) == 0) {



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)