You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2016/02/05 00:20:02 UTC

Review Request 43227: if wan event retry caused the verstion tag is not created, do not distribute the event

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43227/
-----------------------------------------------------------

Review request for geode and Dan Smith.


Bugs: GEODE-774
    https://issues.apache.org/jira/browse/GEODE-774


Repository: geode


Description
-------

The GEODE-774's fix is enhanced. It will distribute when concurrentCheck is not enabled. 
And add junit test for both virtualPut and basicDestroy


Diffs
-----

  gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 46c2eb3 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java 98e72bd 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java fae381f 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java 92b585a 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 9cf2f13 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 256e293 
  gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/BucketRegionJUnitTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/43227/diff/


Testing
-------

precheckin

Following BTs are running:
legacyDunit/batterytest.bt ;
smokeTest/batterytest.bt
newWan/newwanSanity.bt ;
newWan/newWanRebalance.bt ;
newWan/newWanEviction.bt
newWan/dispatcherthreads/queuePersist.bt;
newWan/dispatcherthreads/newWanDispatcherThreads.bt;
versioning/newWan/wanVersioning.bt;
newWan/newWanSenderOperations.bt;
newWan/wanParallelP2P.bt;
newWan/newWanSerialParReg.bt;
newWan/newWanParallelParReg.bt;
newWan/newWan.bt;
newWan/newWanBasic.bt;
newWan/newWanParRegHA.bt
parReg/parReg.bt
parReg/parRegHA.bt
parReg/parRegBridgePersist.bt
parReg/parRegHABridgePersist.bt


Thanks,

xiaojian zhou

Re: Review Request 43227: if wan event retry caused the verstion tag is not created, do not distribute the event

Posted by Swapnil Bawaskar <sb...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43227/#review117932
-----------------------------------------------------------




gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java (line 539)
<https://reviews.apache.org/r/43227/#comment179230>

    Could you please create a method for checking this condition, so that we have to make a change in one place in the future?


- Swapnil Bawaskar


On Feb. 4, 2016, 11:20 p.m., xiaojian zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43227/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 11:20 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: GEODE-774
>     https://issues.apache.org/jira/browse/GEODE-774
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The GEODE-774's fix is enhanced. It will distribute when concurrentCheck is not enabled. 
> And add junit test for both virtualPut and basicDestroy
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 46c2eb3 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java 98e72bd 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java fae381f 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java 92b585a 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 9cf2f13 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 256e293 
>   gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/BucketRegionJUnitTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43227/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> Following BTs are running:
> legacyDunit/batterytest.bt ;
> smokeTest/batterytest.bt
> newWan/newwanSanity.bt ;
> newWan/newWanRebalance.bt ;
> newWan/newWanEviction.bt
> newWan/dispatcherthreads/queuePersist.bt;
> newWan/dispatcherthreads/newWanDispatcherThreads.bt;
> versioning/newWan/wanVersioning.bt;
> newWan/newWanSenderOperations.bt;
> newWan/wanParallelP2P.bt;
> newWan/newWanSerialParReg.bt;
> newWan/newWanParallelParReg.bt;
> newWan/newWan.bt;
> newWan/newWanBasic.bt;
> newWan/newWanParRegHA.bt
> parReg/parReg.bt
> parReg/parRegHA.bt
> parReg/parRegBridgePersist.bt
> parReg/parRegHABridgePersist.bt
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>

Re: Review Request 43227: if wan event retry caused the verstion tag is not created, do not distribute the event

Posted by Dan Smith <ds...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43227/#review117919
-----------------------------------------------------------


Ship it!




Nice work getting BucketRegion under test!

- Dan Smith


On Feb. 4, 2016, 11:20 p.m., xiaojian zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43227/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 11:20 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: GEODE-774
>     https://issues.apache.org/jira/browse/GEODE-774
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The GEODE-774's fix is enhanced. It will distribute when concurrentCheck is not enabled. 
> And add junit test for both virtualPut and basicDestroy
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 46c2eb3 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java 98e72bd 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java fae381f 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java 92b585a 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 9cf2f13 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 256e293 
>   gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/BucketRegionJUnitTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43227/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> Following BTs are running:
> legacyDunit/batterytest.bt ;
> smokeTest/batterytest.bt
> newWan/newwanSanity.bt ;
> newWan/newWanRebalance.bt ;
> newWan/newWanEviction.bt
> newWan/dispatcherthreads/queuePersist.bt;
> newWan/dispatcherthreads/newWanDispatcherThreads.bt;
> versioning/newWan/wanVersioning.bt;
> newWan/newWanSenderOperations.bt;
> newWan/wanParallelP2P.bt;
> newWan/newWanSerialParReg.bt;
> newWan/newWanParallelParReg.bt;
> newWan/newWan.bt;
> newWan/newWanBasic.bt;
> newWan/newWanParRegHA.bt
> parReg/parReg.bt
> parReg/parRegHA.bt
> parReg/parRegBridgePersist.bt
> parReg/parRegHABridgePersist.bt
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>