You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by ha...@apache.org on 2024/03/05 02:29:48 UTC
(iotdb) 17/22: Pipe: Removed mayLinkedTsFileCountReachDangerousThreshold judgement from stuck restart logic (#12041)
This is an automated email from the ASF dual-hosted git repository.
haonan pushed a commit to branch rc/1.3.1
in repository https://gitbox.apache.org/repos/asf/iotdb.git
commit 084e34b154b8d23424e289ec81c629ceefa5b882
Author: Caideyipi <87...@users.noreply.github.com>
AuthorDate: Sun Feb 18 12:56:41 2024 +0800
Pipe: Removed mayLinkedTsFileCountReachDangerousThreshold judgement from stuck restart logic (#12041)
This logic may cause forever restarting when tsFile num is very large or the sending itself is slow.
---
.../apache/iotdb/db/pipe/agent/task/PipeTaskDataNodeAgent.java | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/PipeTaskDataNodeAgent.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/PipeTaskDataNodeAgent.java
index a42adb7cdc8..4f7dde606c8 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/PipeTaskDataNodeAgent.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/PipeTaskDataNodeAgent.java
@@ -349,9 +349,7 @@ public class PipeTaskDataNodeAgent extends PipeTaskAgent {
continue;
}
- if (mayLinkedTsFileCountReachDangerousThreshold()
- || mayMemTablePinnedCountReachDangerousThreshold()
- || mayWalSizeReachThrottleThreshold()) {
+ if (mayMemTablePinnedCountReachDangerousThreshold() || mayWalSizeReachThrottleThreshold()) {
LOGGER.warn("Pipe {} may be stuck.", pipeMeta.getStaticMeta());
stuckPipes.add(pipeMeta);
}
@@ -361,11 +359,6 @@ public class PipeTaskDataNodeAgent extends PipeTaskAgent {
stuckPipes.parallelStream().forEach(this::restartStuckPipe);
}
- private boolean mayLinkedTsFileCountReachDangerousThreshold() {
- return PipeResourceManager.tsfile().getLinkedTsfileCount()
- >= 2 * PipeConfig.getInstance().getPipeMaxAllowedLinkedTsFileCount();
- }
-
private boolean mayMemTablePinnedCountReachDangerousThreshold() {
return PipeResourceManager.wal().getPinnedWalCount()
>= 10 * PipeConfig.getInstance().getPipeMaxAllowedPinnedMemTableCount();