You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/25 04:03:35 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35309: [SPARK-38012][SQL] Rename `MEMORY_MODE` in `VectorizedParquetRecordReader` to `memoryMode`
HyukjinKwon commented on a change in pull request #35309:
URL: https://github.com/apache/spark/pull/35309#discussion_r791339225
##########
File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
##########
@@ -130,7 +130,7 @@
/**
* The memory mode of the columnarBatch
*/
- private final MemoryMode MEMORY_MODE;
+ private final MemoryMode memoryMode;
Review comment:
I guess it's fine since the PR is already open but let's avoid making some cosmetic changes alone in a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org