You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ws.apache.org by ve...@apache.org on 2012/07/08 19:10:02 UTC
svn commit: r1358786 - in
/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom:
om/impl/builder/SAXOMBuilder.java om/impl/builder/StAXOMBuilder.java
soap/impl/builder/StAXSOAPModelBuilder.java
Author: veithen
Date: Sun Jul 8 17:10:02 2012
New Revision: 1358786
URL: http://svn.apache.org/viewvc?rev=1358786&view=rev
Log:
Removed unnecessary code. Since the OMFactory eventually calls addNode, no need to update firstChild/nextSibling/previousSibling.
Modified:
webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/SAXOMBuilder.java
webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/StAXOMBuilder.java
webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/impl/builder/StAXSOAPModelBuilder.java
Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/SAXOMBuilder.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/SAXOMBuilder.java?rev=1358786&r1=1358785&r2=1358786&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/SAXOMBuilder.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/SAXOMBuilder.java Sun Jul 8 17:10:02 2012
@@ -77,16 +77,6 @@ public class SAXOMBuilder extends Defaul
}
private void addNode(OMNode node) {
- if (lastNode != null) {
- if (lastNode.isComplete()) {
- ((OMNodeEx) lastNode).setNextOMSibling(node);
- ((OMNodeEx) node).setPreviousOMSibling(lastNode);
- } else {
- ((OMContainerEx) lastNode).setFirstChild(node);
- }
- } else if (document != null) {
- ((OMContainerEx)document).setFirstChild(node);
- }
if (root == null && node instanceof OMElement) {
root = (OMElement)node;
}
Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/StAXOMBuilder.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/StAXOMBuilder.java?rev=1358786&r1=1358785&r2=1358786&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/StAXOMBuilder.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/StAXOMBuilder.java Sun Jul 8 17:10:02 2012
@@ -461,8 +461,6 @@ public class StAXOMBuilder extends StAXB
} else if (lastNode.isComplete()) {
node = omfactory.createOMElement(elementName, lastNode.getParent(),
this);
- ((OMNodeEx) lastNode).setNextOMSibling(node);
- ((OMNodeEx) node).setPreviousOMSibling(lastNode);
} else {
OMContainerEx e = (OMContainerEx) lastNode;
node = omfactory.createOMElement(elementName, (OMElement) lastNode,
Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/impl/builder/StAXSOAPModelBuilder.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/impl/builder/StAXSOAPModelBuilder.java?rev=1358786&r1=1358785&r2=1358786&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/impl/builder/StAXSOAPModelBuilder.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/impl/builder/StAXSOAPModelBuilder.java Sun Jul 8 17:10:02 2012
@@ -259,8 +259,6 @@ public class StAXSOAPModelBuilder extend
node = constructNode((OMElement)parent,
elementName,
false);
- ((OMNodeEx) lastNode).setNextOMSibling(node);
- ((OMNodeEx) node).setPreviousOMSibling(lastNode);
}
} else {
OMContainerEx e = (OMContainerEx) lastNode;