[jira] Commented: (OPENEJB-955) Wrong error message during install for Tomcat

["Jonathan Gallimore (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENEJB-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649178#action_12649178 ] 

Jonathan Gallimore commented on OPENEJB-955:
--------------------------------------------

Many thanks for the patch! I've committed it  - r719089.

I'll leave this issue open and have a look at part 2

> Wrong error message during install for Tomcat
> ---------------------------------------------
>
>                 Key: OPENEJB-955
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-955
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: tomcat
>    Affects Versions: 3.1
>         Environment: Unix/Linux
>            Reporter: Rudi Tairow
>            Assignee: Jonathan Gallimore
>            Priority: Minor
>         Attachments: openejb.patch
>
>
> During OpenEJB installation using the OpenEJB Tomcat-Installer the installer checks the existence of the files catalina.sh and catalina.bat. If one of those does not exist, the installer produces the message
> "Catalina catalina.sh file does not exist".
> Note that it says "catalina.sh", even if the missing file is catalina.bat.
> On many Unix/Linux systems, catalina.bat is removed, since it is never used.
> Fix part 1: Change error message when checking catalina.bat (trivial, patch attached)
> Fix part 2: Don't try to fix catalina.bat on Unix/Linux when non-existing, don't try to fix catalina.sh on Windows when not existing (don't abort installation)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.