Re: [PR] [KYUUBI #5331] Spark engine should throw an exception when it fails to start [kyuubi]

["wForget (via GitHub)" <gi...@apache.org>]

wForget commented on code in PR #5332:
URL: https://github.com/apache/kyuubi/pull/5332#discussion_r1387395581


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala:
##########
@@ -379,7 +381,11 @@ object SparkSQLEngine extends Logging {
               s" The `${ENGINE_INIT_TIMEOUT.key}` is ($initTimeout ms) " +
               s" and submitted at $submitTime.",
             i)
-        case t: Throwable => error(s"Failed to instantiate SparkSession: ${t.getMessage}", t)
+          throw i

Review Comment:
   Wrap exception with errorMsg.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org