You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Jyoti Singh <sj...@gmail.com> on 2020/08/03 17:59:43 UTC

Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72730/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
    https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
-------

- Added basic structure for Python client
- This includes all classes for Entity and TypeDef
- Added all endpoints for typedef


Diffs
-----

  client/client-v2/src/main/python/atlas_discovery.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_entity.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_typedef.py PRE-CREATION 
  client/client-v2/src/main/python/base_client.py PRE-CREATION 
  client/client-v2/src/main/python/entity_client.py PRE-CREATION 
  client/client-v2/src/main/python/glossary.py PRE-CREATION 
  client/client-v2/src/main/python/typedef_client.py PRE-CREATION 
  client/client-v2/src/main/python/utils.py PRE-CREATION 


Diff: https://reviews.apache.org/r/72730/diff/1/


Testing
-------

Tested on local.


Thanks,

Jyoti Singh

Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python

Posted by Jyoti Singh <sj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72730/
-----------------------------------------------------------

(Updated Aug. 17, 2020, 4:13 a.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
    https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description (updated)
-------

- Added basic structure for Python client
- This includes all classes for Entity and TypeDef
- Added all endpoints for typedef, Entity, Glossary, Lineage and Relationship
- Added Python Sample project to test basic APIs and as a guideline
- Added logging and readme file


Diffs
-----

  .gitignore 90ca27646 
  atlas-examples/sample-app/src/main/python/README.md PRE-CREATION 
  atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION 
  client/client-v2/src/main/python/LICENSE PRE-CREATION 
  client/client-v2/src/main/python/README.md PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/__init__.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/discovery.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/entity.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/glossary.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/lineage.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/relationship.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/typedef.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/exceptions.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/__init__.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/discovery.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/entity.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/glossary.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/lineage.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/relationship.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/typedef.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION 
  client/client-v2/src/main/python/requirements.txt PRE-CREATION 
  client/client-v2/src/main/python/setup.py PRE-CREATION 
  client/client-v2/src/main/python/tests/__init__.py PRE-CREATION 
  client/client-v2/src/main/resources/logging.conf PRE-CREATION 


Diff: https://reviews.apache.org/r/72730/diff/5/


Testing
-------

Tested on local.


Thanks,

Jyoti Singh

Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python

Posted by Jyoti Singh <sj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72730/
-----------------------------------------------------------

(Updated Aug. 17, 2020, 4:07 a.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.


Changes
-------

Code Review Related Change


Bugs: ATLAS-3875
    https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
-------

- Added basic structure for Python client
- This includes all classes for Entity and TypeDef
- Added all endpoints for typedef


Diffs (updated)
-----

  .gitignore 90ca27646 
  atlas-examples/sample-app/src/main/python/README.md PRE-CREATION 
  atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION 
  client/client-v2/src/main/python/LICENSE PRE-CREATION 
  client/client-v2/src/main/python/README.md PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/__init__.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/discovery.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/entity.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/glossary.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/lineage.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/relationship.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/client/typedef.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/exceptions.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/__init__.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/discovery.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/entity.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/glossary.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/lineage.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/relationship.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/model/typedef.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION 
  client/client-v2/src/main/python/requirements.txt PRE-CREATION 
  client/client-v2/src/main/python/setup.py PRE-CREATION 
  client/client-v2/src/main/python/tests/__init__.py PRE-CREATION 
  client/client-v2/src/main/resources/logging.conf PRE-CREATION 


Diff: https://reviews.apache.org/r/72730/diff/5/

Changes: https://reviews.apache.org/r/72730/diff/4-5/


Testing
-------

Tested on local.


Thanks,

Jyoti Singh

Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python

Posted by Jyoti Singh <sj...@gmail.com>.

> On Aug. 11, 2020, 6:50 p.m., Sidharth Mishra wrote:
> > client/client-v2/src/main/python/atlas_client/discovery_model.py
> > Lines 22 (patched)
> > <https://reviews.apache.org/r/72730/diff/4/?file=2237707#file2237707line22>
> >
> >     Please remove one extra blank line (we always keep one blank line as separator if needed)

For Python classes we have to add 2 blank lines between imports and class name.
https://www.python.org/dev/peps/pep-0008/#blank-lines


- Jyoti


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72730/#review221546
-----------------------------------------------------------


On Aug. 10, 2020, 5:26 p.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72730/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2020, 5:26 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - Added basic structure for Python client
> - This includes all classes for Entity and TypeDef
> - Added all endpoints for typedef
> 
> 
> Diffs
> -----
> 
>   atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION 
>   client/client-v2/src/main/python/LICENSE PRE-CREATION 
>   client/client-v2/src/main/python/README.md PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/discovery_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/discovery_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/entity_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/entity_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/glossary_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/glossary_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/lineage_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/lineage_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/relationship_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/relationship_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/typedef_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/typedef_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION 
>   client/client-v2/src/main/python/requirements.txt PRE-CREATION 
>   client/client-v2/src/main/python/setup.py PRE-CREATION 
>   client/client-v2/src/main/python/tests/__init__.py PRE-CREATION 
>   client/client-v2/src/main/resources/logging.conf PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72730/diff/4/
> 
> 
> Testing
> -------
> 
> Tested on local.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python

Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72730/#review221546
-----------------------------------------------------------




atlas-examples/sample-app/src/main/python/discovery_example.py
Lines 3 (patched)
<https://reviews.apache.org/r/72730/#comment310609>

    Remove two extra blank lines. Along with this please add content to README.md file as well



atlas-examples/sample-app/src/main/python/discovery_example.py
Lines 12 (patched)
<https://reviews.apache.org/r/72730/#comment310601>

    should we rename it to something more meaningful?



atlas-examples/sample-app/src/main/python/utils.py
Lines 11 (patched)
<https://reviews.apache.org/r/72730/#comment310600>

    I think it will be good to rename these const to have some prefix like CUSTOM or SAMPLE to differentiate between the existing table types.



client/client-v2/src/main/python/atlas_client/base_client.py
Lines 84 (patched)
<https://reviews.apache.org/r/72730/#comment310602>

    Should we have custom exceptions like AtlasException instead of Exception thrown from most of the python client similar to Java client. This will help the users of the client to handle appropriately and distinguish from the generic python exceptions



client/client-v2/src/main/python/atlas_client/discovery_client.py
Lines 6 (patched)
<https://reviews.apache.org/r/72730/#comment310608>

    Remove one extra blank line



client/client-v2/src/main/python/atlas_client/discovery_client.py
Lines 20 (patched)
<https://reviews.apache.org/r/72730/#comment310603>

    Can we have vertical indentation like:
    
        DSL_SEARCH       = API(DSL_SEARCH_URI, HttpMethod.GET, HTTPStatus.OK)
        FULL_TEXT_SEARCH = API(FULL_TEXT_SEARCH_URI, HttpMethod.GET, HTTPStatus.OK)
        BASIC_SEARCH     = API(BASIC_SEARCH_URI, HttpMethod.GET, HTTPStatus.OK)
        FACETED_SEARCH   = API(FACETED_SEARCH_URI, HttpMethod.POST, HTTPStatus.OK)
        ATTRIBUTE_SEARCH = API(DISCOVERY_URI + "/attribute", HttpMethod.GET, HTTPStatus.OK)
        
    In case you are changing please take care of this at other places



client/client-v2/src/main/python/atlas_client/discovery_model.py
Lines 18 (patched)
<https://reviews.apache.org/r/72730/#comment310606>

    Add blank line after the header comment. Please do at other files as well



client/client-v2/src/main/python/atlas_client/discovery_model.py
Lines 22 (patched)
<https://reviews.apache.org/r/72730/#comment310604>

    Please remove one extra blank line (we always keep one blank line as separator if needed)



client/client-v2/src/main/python/atlas_client/discovery_model.py
Lines 145 (patched)
<https://reviews.apache.org/r/72730/#comment310607>

    Please remove if not needed


- Sidharth Mishra


On Aug. 10, 2020, 5:26 p.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72730/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2020, 5:26 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - Added basic structure for Python client
> - This includes all classes for Entity and TypeDef
> - Added all endpoints for typedef
> 
> 
> Diffs
> -----
> 
>   atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION 
>   client/client-v2/src/main/python/LICENSE PRE-CREATION 
>   client/client-v2/src/main/python/README.md PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/discovery_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/discovery_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/entity_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/entity_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/glossary_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/glossary_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/lineage_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/lineage_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/relationship_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/relationship_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/typedef_client.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/typedef_model.py PRE-CREATION 
>   client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION 
>   client/client-v2/src/main/python/requirements.txt PRE-CREATION 
>   client/client-v2/src/main/python/setup.py PRE-CREATION 
>   client/client-v2/src/main/python/tests/__init__.py PRE-CREATION 
>   client/client-v2/src/main/resources/logging.conf PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72730/diff/4/
> 
> 
> Testing
> -------
> 
> Tested on local.
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python

Posted by Jyoti Singh <sj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72730/
-----------------------------------------------------------

(Updated Aug. 10, 2020, 5:26 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
    https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
-------

- Added basic structure for Python client
- This includes all classes for Entity and TypeDef
- Added all endpoints for typedef


Diffs (updated)
-----

  atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION 
  atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION 
  client/client-v2/src/main/python/LICENSE PRE-CREATION 
  client/client-v2/src/main/python/README.md PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/discovery_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/discovery_model.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/entity_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/entity_model.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/glossary_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/glossary_model.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/lineage_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/lineage_model.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/relationship_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/relationship_model.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/typedef_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/typedef_model.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION 
  client/client-v2/src/main/python/requirements.txt PRE-CREATION 
  client/client-v2/src/main/python/setup.py PRE-CREATION 
  client/client-v2/src/main/python/tests/__init__.py PRE-CREATION 
  client/client-v2/src/main/resources/logging.conf PRE-CREATION 


Diff: https://reviews.apache.org/r/72730/diff/4/

Changes: https://reviews.apache.org/r/72730/diff/3-4/


Testing
-------

Tested on local.


Thanks,

Jyoti Singh

Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python

Posted by Jyoti Singh <sj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72730/
-----------------------------------------------------------

(Updated Aug. 6, 2020, 3:31 a.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
    https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
-------

- Added basic structure for Python client
- This includes all classes for Entity and TypeDef
- Added all endpoints for typedef


Diffs (updated)
-----

  atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION 
  client/client-v2/src/main/python/LICENSE PRE-CREATION 
  client/client-v2/src/main/python/README.md PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/atlas_discovery.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/atlas_entity.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/atlas_glossary.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/atlas_lineage.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/atlas_typedef.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/discovery_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/entity_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/glossary_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/lineage_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/relationship_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/typedef_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION 
  client/client-v2/src/main/python/requirements.txt PRE-CREATION 
  client/client-v2/src/main/python/setup.py PRE-CREATION 
  client/client-v2/src/main/python/tests/__init__.py PRE-CREATION 
  client/client-v2/src/main/resources/logging.conf PRE-CREATION 


Diff: https://reviews.apache.org/r/72730/diff/3/

Changes: https://reviews.apache.org/r/72730/diff/2-3/


Testing
-------

Tested on local.


Thanks,

Jyoti Singh

Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python

Posted by Jyoti Singh <sj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72730/
-----------------------------------------------------------

(Updated Aug. 3, 2020, 6 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
    https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
-------

- Added basic structure for Python client
- This includes all classes for Entity and TypeDef
- Added all endpoints for typedef


Diffs (updated)
-----

  client/client-v2/src/main/python/atlas_discovery.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_entity.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_typedef.py PRE-CREATION 
  client/client-v2/src/main/python/base_client.py PRE-CREATION 
  client/client-v2/src/main/python/entity_client.py PRE-CREATION 
  client/client-v2/src/main/python/glossary.py PRE-CREATION 
  client/client-v2/src/main/python/typedef_client.py PRE-CREATION 
  client/client-v2/src/main/python/utils.py PRE-CREATION 


Diff: https://reviews.apache.org/r/72730/diff/2/

Changes: https://reviews.apache.org/r/72730/diff/1-2/


Testing
-------

Tested on local.


Thanks,

Jyoti Singh