You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/09/24 03:22:00 UTC
[jira] [Commented] (IMPALA-10928) Upgrade source of Kudu's EasyCurl
in kudu/util
[ https://issues.apache.org/jira/browse/IMPALA-10928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419543#comment-17419543 ]
ASF subversion and git services commented on IMPALA-10928:
----------------------------------------------------------
Commit 20e07f8645b402f08af91e6b078d1fdd2a0d06f6 in impala's branch refs/heads/master from wzhou-code
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=20e07f8 ]
IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util
We are going to use Kudu's EasyCurl wrapper to download file in Impala.
There are some enhancements for Kudu's EasyCurl in Kudu upstream since
the last sync of kudu/util with Kudu repo. This patch upgraded source
code for Kudu's EasyCurl wrapper (curl_util.cc and curl_util.h in
kudu/util) from the Kudu upstream (commit hash: 37bc427a60, b417479266,
a33b0951d9, 9050941663, e371d80f3e).
Note that curl_util.cc/curl_util.h have dependency on libcurl, which
is not integrated in Impala. curl_util.cc is not built with current
kudu/util/CMakeLists.txt. We will integrate curl_util.cc/curl_util.h
when we integrate libcurl in following patch.
Testing:
- There is no impact for Impala tests.
Change-Id: I51fea9ff4de767bfda2a4ebcd3744d63440adf14
Reviewed-on: http://gerrit.cloudera.org:8080/17864
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Upgrade source of Kudu's EasyCurl in kudu/util
> ----------------------------------------------
>
> Key: IMPALA-10928
> URL: https://issues.apache.org/jira/browse/IMPALA-10928
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Wenzhe Zhou
> Assignee: Wenzhe Zhou
> Priority: Major
>
> We are going to use Kudu's EasyCurl wrapper to download file in Impala.
> There are some enhancements for Kudu's EasyCurl in Kudu upstream since the last sync of kudu/util with Kudu repo. The Kudu's EasyCurl wrapper (curl_util.cc/curl_util.h) only have dependency on libcurl so we can upgrade the source of EasyCurl without updating other source code in kudu/util.
> This include changes in following Kudu's patches (1/24/2020 - 2/9/2021):
> [[test] Fix InstanceDetectorTest.Timeout when run on AWS|https://github.com/apache/kudu/commit/37bc427a60f9cb3ab687d3610b50199f12875a08#diff-03c44f723ec14b6a04863ef9e99b9b0524d655d92ffdd0db4cf2b4faa1f8ce92] (37bc427a60)
> [KUDU-3079 Add MiniRanger (b417479266)|https://github.com/apache/kudu/commit/b417479266ef0f09570d4536738ca18cf48d7ff2#diff-03c44f723ec14b6a04863ef9e99b9b0524d655d92ffdd0db4cf2b4faa1f8ce92]
> [[util] set CURLOPT_NOPROXY for EasyCurl|https://github.com/apache/kudu/commit/a33b0951d91ecb0b84871bbf9d4b4b3550196af5#diff-03c44f723ec14b6a04863ef9e99b9b0524d655d92ffdd0db4cf2b4faa1f8ce92] (a33b0951d9)
> [[util] add CURLOPT_FAILONERROR for instance metadata requests (9050941663)|https://github.com/apache/kudu/commit/9050941663e532db29bd25cb7170712a80d945ea#diff-03c44f723ec14b6a04863ef9e99b9b0524d655d92ffdd0db4cf2b4faa1f8ce92]
> [[util] add error buffer for EasyCurl wrapper|https://github.com/apache/kudu/commit/e371d80f3e2ab171f704db198125ae8f8a860a6d#diff-03c44f723ec14b6a04863ef9e99b9b0524d655d92ffdd0db4cf2b4faa1f8ce92] (e371d80f3e)
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org