[jira] [Closed] (SLING-5029) ModelFactory.canCreateFromAdaptable can report false positives

["Stefan Seifert (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-5029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Seifert closed SLING-5029.
---------------------------------

> ModelFactory.canCreateFromAdaptable can report false positives
> --------------------------------------------------------------
>
>                 Key: SLING-5029
>                 URL: https://issues.apache.org/jira/browse/SLING-5029
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Sling Models Impl 1.2.2
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Minor
>              Labels: models
>             Fix For: Sling Models API 1.2.4, Sling Models Impl 1.2.6
>
>
> As being mentioned by [~sseifert@pro-vision.de] in https://issues.apache.org/jira/browse/SLING-4997?focusedCommentId=14734059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14734059 the method {{ModelFactory.canCreateFromAdaptable}} may return false positives in case the class has a model annotation but is still not registered due to last line in {{ModelFactory.getImplementationTypeForAdapterType(...)}}.
> In the best case an exception should be thrown if the class has a Model annotation but is still not registered (but probably that is not easily possible to detect in case of different adapter classes). Therefore at least the handling should be consistent here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)