You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Andrzej Bialecki (Created) (JIRA)" <ji...@apache.org> on 2012/04/05 17:18:24 UTC
[jira] [Created] (SOLR-3322) Add more context to
IndexReaderFactory.newReader
Add more context to IndexReaderFactory.newReader
------------------------------------------------
Key: SOLR-3322
URL: https://issues.apache.org/jira/browse/SOLR-3322
Project: Solr
Issue Type: Improvement
Affects Versions: 4.0
Reporter: Andrzej Bialecki
Assignee: Andrzej Bialecki
Fix For: 4.0
In some situations where a custom IndexReaderFactory is used the amount of information passed to the newReader(..) call is too small. E.g. if a factory needs to access some external data that depends on schema or even on the collection name then it has no way to obtain that context.
We cannot use SolrCoreAware here because this method is called before SolrCore is ready.
I propose to simply change the signature and add a SolrCore argument. Even though SolrCore is not fully valid at this point, still the most useful properties there are valid (schema, descriptor, config, etc...).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3322) Add more context to
IndexReaderFactory.newReader
Posted by "Andrzej Bialecki (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrzej Bialecki updated SOLR-3322:
------------------------------------
Attachment: SOLR-3322.patch
Patch that implements the change. If there are no objections I'd like to commit shortly.
> Add more context to IndexReaderFactory.newReader
> ------------------------------------------------
>
> Key: SOLR-3322
> URL: https://issues.apache.org/jira/browse/SOLR-3322
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Fix For: 4.0
>
> Attachments: SOLR-3322.patch
>
>
> In some situations where a custom IndexReaderFactory is used the amount of information passed to the newReader(..) call is too small. E.g. if a factory needs to access some external data that depends on schema or even on the collection name then it has no way to obtain that context.
> We cannot use SolrCoreAware here because this method is called before SolrCore is ready.
> I propose to simply change the signature and add a SolrCore argument. Even though SolrCore is not fully valid at this point, still the most useful properties there are valid (schema, descriptor, config, etc...).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3322) Add more context to
IndexReaderFactory.newReader
Posted by "Andrzej Bialecki (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrzej Bialecki resolved SOLR-3322.
-------------------------------------
Resolution: Fixed
Committed in rev. 1311812.
> Add more context to IndexReaderFactory.newReader
> ------------------------------------------------
>
> Key: SOLR-3322
> URL: https://issues.apache.org/jira/browse/SOLR-3322
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Fix For: 4.0
>
> Attachments: SOLR-3322.patch
>
>
> In some situations where a custom IndexReaderFactory is used the amount of information passed to the newReader(..) call is too small. E.g. if a factory needs to access some external data that depends on schema or even on the collection name then it has no way to obtain that context.
> We cannot use SolrCoreAware here because this method is called before SolrCore is ready.
> I propose to simply change the signature and add a SolrCore argument. Even though SolrCore is not fully valid at this point, still the most useful properties there are valid (schema, descriptor, config, etc...).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org