[jira] [Commented] (GORA-27) Optionally add license headers to generated files

["Lewis John McGibbney (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GORA-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531090#comment-13531090 ] 

Lewis John McGibbney commented on GORA-27:
------------------------------------------

Hi Renato, this looks great and works well. I have two comments.
1. Do we wish to have a default license header? E.g. is the user does NOT wish to pick a license, by default we add ASLv2? After all, we are running under the Apache brand. 
2. Should the log.info statement in compileProtocol not read
{code}
log.info("The generated file will be " + licenseHeader.getLicenseName() + " licensed.");
{code}
to shadow the implementation you've written for the compileSchema class?

FInally, I think this patch, once implemented would also be of interest to the guys over at Avro. As you know they maintain the SpecificCompiler, and the functionality to specify license headers may be of interest to them.
Great work, once the above have been addressed I am +1 for commit.
                
> Optionally add license headers to generated files
> -------------------------------------------------
>
>                 Key: GORA-27
>                 URL: https://issues.apache.org/jira/browse/GORA-27
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: schema
>    Affects Versions: 0.1-incubating, 0.2
>            Reporter: Andrzej Bialecki 
>             Fix For: 0.3
>
>         Attachments: GORA-27.patch, GORA-27-v2.patch, GORA-27v4.patch
>
>
> Gora compiler should allow adding license headers to generated files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira