You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sergio Bossa (JIRA)" <ji...@apache.org> on 2015/10/26 20:07:27 UTC

[jira] [Commented] (CASSANDRA-10595) Don't initialize un-registered indexes

    [ https://issues.apache.org/jira/browse/CASSANDRA-10595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974844#comment-14974844 ] 

Sergio Bossa commented on CASSANDRA-10595:
------------------------------------------

The patch looks good, I have only one concern: there's some mixed usage of {{Index#getIndexName()}} and {{IndexMetadata#name}}, which are apparently assumed to be the same but there's no actual "constraint" about that API-wise, so wouldn't it be better to just drop the former?

> Don't initialize un-registered indexes
> --------------------------------------
>
>                 Key: CASSANDRA-10595
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10595
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>            Priority: Minor
>             Fix For: 3.0.0
>
>
> If a secondary index implementation chooses not to register with {{SecondaryIndexManager}} on a particular node, it won't be required to provide either {{Indexer}} or {{Searcher}} instances. In this case, initialization is unnecessary so we should avoid doing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)