[PR] Remove keyGenerateStrategy for ShardingTableRuleConfiguration [shardingsphere]

["zhaojinchao95 (via GitHub)" <gi...@apache.org>]

zhaojinchao95 opened a new pull request, #38609:
URL: https://github.com/apache/shardingsphere/pull/38609

   For #38178 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove keyGenerateStrategy for ShardingTableRuleConfiguration [shardingsphere]

["zhaojinchao95 (via GitHub)" <gi...@apache.org>]

zhaojinchao95 merged PR #38609:
URL: https://github.com/apache/shardingsphere/pull/38609


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove keyGenerateStrategy for ShardingTableRuleConfiguration [shardingsphere]

["zhaojinchao95 (via GitHub)" <gi...@apache.org>]

zhaojinchao95 commented on PR #38609:
URL: https://github.com/apache/shardingsphere/pull/38609#issuecomment-4234142153

   • The current review rule does not allow skipping this check.
   
     This PR still includes an unrelated change in .github/workflows/graalvm.yml, so I cannot mark it as Mergeable in its current state. Even though the defaultKeyGenerateStrategy regression appears to be fixed, unrelated changes still need to be removed from
     this PR rather than deferred to a follow-up PR.
   
     If the goal is to confirm whether the core sharding change is otherwise acceptable, my current view is:
   
     - The defaultKeyGenerateStrategy semantic regression has been addressed.
     - The remaining blocker is that .github/workflows/graalvm.yml is still part of this PR and is unrelated to the stated goal.
   
     So the current conclusion is still:
   
     - Merge Verdict: Not Mergeable
   
     The minimum next step is:
   
     - Remove .github/workflows/graalvm.yml from this PR, and then I can do a final focused pass.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org