[jira] [Commented] (AMBARI-22110) Some ResourceProviders Are Not Transactional

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-22110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188409#comment-16188409 ] 

Hadoop QA commented on AMBARI-22110:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12889971/AMBARI-22110.patch
  against trunk revision .

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/12400//console

This message is automatically generated.

> Some ResourceProviders Are Not Transactional
> --------------------------------------------
>
>                 Key: AMBARI-22110
>                 URL: https://issues.apache.org/jira/browse/AMBARI-22110
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>            Reporter: Nate Cole
>            Assignee: Nate Cole
>            Priority: Critical
>             Fix For: 2.6.0
>
>         Attachments: AMBARI-22110.patch
>
>
> While investigating an issue with VDFs which don't contain any OS's which match the cluster, it was observed that, even after throwing an Exception inside of a Transaction, the entities created inside that transaction were being committed. 
> Eventual investigation led to a problem between Guice/AOP and our ResourceProviders. The Guice documentations says that {{@Transactional}} methods can only be intercepted on objects created by Guice:
> https://github.com/google/guice/wiki/AOP:
> {quote}
> Instances must be created by Guice by an @Inject-annotated or no-argument constructor It is not possible to use method interception on instances that aren't constructed by Guice.
> {quote}
> However, some of the ResourceProviders which use {{@Transactional}} are not constructed by Guice.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)