You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "William Bardwell (JIRA)" <ji...@apache.org> on 2011/06/07 17:06:58 UTC
[jira] [Created] (TS-825) negative caching caches responses that
should never be cached
negative caching caches responses that should never be cached
-------------------------------------------------------------
Key: TS-825
URL: https://issues.apache.org/jira/browse/TS-825
Project: Traffic Server
Issue Type: Bug
Components: HTTP
Affects Versions: 2.1.4, 2.1.5, 2.1.6, 2.1.7, 2.1.8, 2.1.9
Reporter: William Bardwell
Priority: Minor
If you turn on negative caching almost all status codes are cached. But some of those status codes can not be reasonably cached IMHO and so I would propose not caching 401, 303 and 407 statuses. (The negative caching code ends up marking just about everything as cacheable, and then later decides that some stuff is 'negative cacheable' but things that aren't negative cacheable are still just cached, and there is no way to say 'never cache this'. So you just have to add clauses to HttpTransact::is_response_cacheable(), which is what my patch does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-825) negative caching caches responses that
should never be cached
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reassigned TS-825:
--------------------------------
Assignee: Leif Hedstrom
> negative caching caches responses that should never be cached
> -------------------------------------------------------------
>
> Key: TS-825
> URL: https://issues.apache.org/jira/browse/TS-825
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Reporter: William Bardwell
> Assignee: Leif Hedstrom
> Priority: Minor
> Attachments: negative-caching-patch.diff
>
>
> If you turn on negative caching almost all status codes are cached. But some of those status codes can not be reasonably cached IMHO and so I would propose not caching 401, 303 and 407 statuses. (The negative caching code ends up marking just about everything as cacheable, and then later decides that some stuff is 'negative cacheable' but things that aren't negative cacheable are still just cached, and there is no way to say 'never cache this'. So you just have to add clauses to HttpTransact::is_response_cacheable(), which is what my patch does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-825) negative caching caches responses that
should never be cached
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-825:
-----------------------------
Backport to Version: 3.0.0
Fix Version/s: 3.0.0
3.1.0
Marking this for backporting to 3.0.0 as well, we really do not want to cache things that should never be cached.
> negative caching caches responses that should never be cached
> -------------------------------------------------------------
>
> Key: TS-825
> URL: https://issues.apache.org/jira/browse/TS-825
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Reporter: William Bardwell
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.0, 3.0.0
>
> Attachments: negative-caching-patch.diff
>
>
> If you turn on negative caching almost all status codes are cached. But some of those status codes can not be reasonably cached IMHO and so I would propose not caching 401, 303 and 407 statuses. (The negative caching code ends up marking just about everything as cacheable, and then later decides that some stuff is 'negative cacheable' but things that aren't negative cacheable are still just cached, and there is no way to say 'never cache this'. So you just have to add clauses to HttpTransact::is_response_cacheable(), which is what my patch does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-825) negative caching caches responses that
should never be cached
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046186#comment-13046186 ]
Leif Hedstrom commented on TS-825:
----------------------------------
I have tested / verified that this does indeed turn those three return codes uncacheable.
> negative caching caches responses that should never be cached
> -------------------------------------------------------------
>
> Key: TS-825
> URL: https://issues.apache.org/jira/browse/TS-825
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Reporter: William Bardwell
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.0, 3.0.0
>
> Attachments: negative-caching-patch.diff
>
>
> If you turn on negative caching almost all status codes are cached. But some of those status codes can not be reasonably cached IMHO and so I would propose not caching 401, 303 and 407 statuses. (The negative caching code ends up marking just about everything as cacheable, and then later decides that some stuff is 'negative cacheable' but things that aren't negative cacheable are still just cached, and there is no way to say 'never cache this'. So you just have to add clauses to HttpTransact::is_response_cacheable(), which is what my patch does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-825) negative caching caches responses that
should never be cached
Posted by "William Bardwell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Bardwell updated TS-825:
--------------------------------
Attachment: negative-caching-patch.diff
Patch to fix this for 303, 401, 407
> negative caching caches responses that should never be cached
> -------------------------------------------------------------
>
> Key: TS-825
> URL: https://issues.apache.org/jira/browse/TS-825
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Reporter: William Bardwell
> Priority: Minor
> Attachments: negative-caching-patch.diff
>
>
> If you turn on negative caching almost all status codes are cached. But some of those status codes can not be reasonably cached IMHO and so I would propose not caching 401, 303 and 407 statuses. (The negative caching code ends up marking just about everything as cacheable, and then later decides that some stuff is 'negative cacheable' but things that aren't negative cacheable are still just cached, and there is no way to say 'never cache this'. So you just have to add clauses to HttpTransact::is_response_cacheable(), which is what my patch does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-825) negative caching caches responses that
should never be cached
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-825:
-----------------------------
Backport to Version: (was: 3.0.0)
Fix Version/s: 3.0.0
> negative caching caches responses that should never be cached
> -------------------------------------------------------------
>
> Key: TS-825
> URL: https://issues.apache.org/jira/browse/TS-825
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Reporter: William Bardwell
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.0, 3.0.0
>
> Attachments: negative-caching-patch.diff
>
>
> If you turn on negative caching almost all status codes are cached. But some of those status codes can not be reasonably cached IMHO and so I would propose not caching 401, 303 and 407 statuses. (The negative caching code ends up marking just about everything as cacheable, and then later decides that some stuff is 'negative cacheable' but things that aren't negative cacheable are still just cached, and there is no way to say 'never cache this'. So you just have to add clauses to HttpTransact::is_response_cacheable(), which is what my patch does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-825) negative caching caches responses that
should never be cached
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-825:
-----------------------------
Fix Version/s: (was: 3.0.0)
Removing the 3.0.0 fix version, until the votes on the 3.0.0 backport has passed.
> negative caching caches responses that should never be cached
> -------------------------------------------------------------
>
> Key: TS-825
> URL: https://issues.apache.org/jira/browse/TS-825
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4
> Reporter: William Bardwell
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: negative-caching-patch.diff
>
>
> If you turn on negative caching almost all status codes are cached. But some of those status codes can not be reasonably cached IMHO and so I would propose not caching 401, 303 and 407 statuses. (The negative caching code ends up marking just about everything as cacheable, and then later decides that some stuff is 'negative cacheable' but things that aren't negative cacheable are still just cached, and there is no way to say 'never cache this'. So you just have to add clauses to HttpTransact::is_response_cacheable(), which is what my patch does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira