You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Craeg K Strong <cs...@arielpartners.com> on 2002/05/24 21:30:29 UTC
XMLCatalog.java -- commit missed a smidgen.. and test failure questions
Erik:
Thanks very much for committing my (jumbo) patch!
There was still a tiny bit missing from the header comment of XMLCatalog.java,
plus I removed a typo or two (mine) in the rest. The attached patch should do
it. The patch is _only_ to code comments. All of the source code looks fine.
The test failures, however, are really interesting! I will look into them in
detail, but I need to know your configuration in order to reproduce the problem.
I am guessing you are using the following:
Windows 2000
Apache Xerces 2.0.1 (the one that comes bundled with Ant)
Apache Xalan 2.3.1
Please let me know as soon as possible. I noted in your comments, the assert
failures were all of the nature
Expected "file:/C:/ant1.5Beta/jakarta-ant/src.../doc.dtd"
But Was: "file:C:/ant1.5Beta/jakarta-ant/src.../doc.dtd"
That is, the URL was being formed improperly-- missing the slash after "file:"
I will find the bug.
Either it is an Ant issue, in which case I will submit a patch fix, or
it is a Xalan issue, in which case I will submit a patch workaround.
Regards,
--Craeg
ehatcher@apache.org wrote:
> ehatcher 02/05/24 10:40:23
>
> Modified: src/main/org/apache/tools/ant/types Tag: ANT_15_BRANCH
> XMLCatalog.java
> Log:
> oops.... the patch I previously applied missed the first "chunk". i think i've got it all fixed now.
>
> Revision Changes Path
> No revision
>
>
> No revision
>
>
> 1.9.2.3 +31 -4 jakarta-ant/src/main/org/apache/tools/ant/types/XMLCatalog.java
>
> Index: XMLCatalog.java
> ===================================================================
> RCS file: /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/types/XMLCatalog.java,v
> retrieving revision 1.9.2.2
> retrieving revision 1.9.2.3
> diff -u -r1.9.2.2 -r1.9.2.3
> --- XMLCatalog.java 24 May 2002 15:47:56 -0000 1.9.2.2
> +++ XMLCatalog.java 24 May 2002 17:40:23 -0000 1.9.2.3
> @@ -101,14 +101,31 @@
> * the XMLCatalog object and must be labeled <code>dtd</code> and
> * <code>entity</code> respectively.</p>
> *
> - * <p>Possible future extension could allow a catalog file instead of nested
> - * elements, or use Norman Walsh's entity resolver from xml-commons</p>
> + * <p>The following is a description of the resolution algorithm:
> + * entities/URIs/dtds are looked up in each of the following contexts,
> + * stopping when a valid and readable resource is found:
> + * <ol>
...
[PATCH] XMLCatalogTest.java
Posted by Craeg K Strong <cs...@arielpartners.com>.
Hello:
Attached please find a patch that fixes the failing assertions you
found in XMLCatalogTest.java
What happened: Ant has its own toURL() routine called FileUtils:getFileURL(File)
The algorithm used yields slightly different results than that of
java.io.File.toURL()
but only on Windoze.
Although the URLs are different, both seem to work. Anyway, I just changed the
code to use FileUtils.getFileURL instead of java.io.File.toURL
Of course, I am submitting this on the optimistic assumption that the
aforementioned JAXP jar issue will be resolved :-)
Thanks,
--Craeg
Re: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
Yikes! I was concerned about that when I saw the additional imports, but
because I have Xalan in my bootstrap classpath it worked I guess.
I +1'd including Xalan as its such a fundamental piece to things like
<junitreport> and <xslt> - but I think at least one committer veto'd it? I
still support including it.
So, we must make a decsion soon... either we revert Craeg's patch or we
include Xalan.
Erik
----- Original Message -----
From: "Craeg Strong" <cs...@arielpartners.com>
To: "Ant Developers List" <an...@jakarta.apache.org>;
<ja...@ehatchersolutions.com>
Sent: Friday, May 24, 2002 7:30 PM
Subject: Re: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!
> Hello:
>
> Responses to previous email are down below, but a bigger issue has come
> up.
>
> I never realized until this very moment that the xmlParserAPIs.jar that
> comes with
> Xerces does __NOT__ contain the full JAXP library. Instead, they
> chopped it in half
> and only included the pieces that are actually implemented by xerces.
> This is bad.
>
> XMLCatalog as I have now modified it makes use of the OTHER pieces of
> the JAXP library,
> although it does NOT require actual implementations of the Transformer
> classes
> (that is, neither Xalan nor Saxon have to be on the path).
>
> The problem is, bootstrap.bat / boostrap.sh FAIL to build Ant now
> because of the missing
> APIs. >:-(
>
> What is the best way to fix this? I remember there was some
> discussion about including
> the xalan jar files in Ant/lib: xalan.jar and xml-api.jar
>
> Of course, the Xalan xml-api.jar includes the ENTIRE jaxp library, so
> there would be
> considerable overlap with xerces xmlParserAPIs.jar
>
> Another alternative is to include jaxp.jar from JAXP 1.1 At only 28K,
> it does not add much to the size of the ant download.
>
> Again, however, there would be some overlap with the xerces
> xmlParserAPIs.jar
>
> Anyway, it seems pretty reasonable to me that Ant would include a
> jaxp.jar library,
> as it is intrinsically dependent on much of JAXP. Otherwise, we would
> have to do something
> horribly ugly like breaking up XMLCatalog into two pieces. yuk.
>
> Thoughts?
>
> --Craeg
>
>
> Erik Hatcher wrote:
>
> >Craeg,
> >
> >Ok, I've applied your fix-up patch.
> >
> Thanks!
>
> >
> >
> >
> >>I am guessing you are using the following:
> >>
> >>Windows 2000
> >>Apache Xerces 2.0.1 (the one that comes bundled with Ant)
> >>Apache Xalan 2.3.1
> >>
> >>Please let me know as soon as possible. I noted in your comments, the
> >>
> >>
> >assert
> >
> >
> >>failures were all of the nature
> >>
> >>Expected "file:/C:/ant1.5Beta/jakarta-ant/src.../doc.dtd"
> >>But Was: "file:C:/ant1.5Beta/jakarta-ant/src.../doc.dtd"
> >>
> >>That is, the URL was being formed improperly-- missing the slash after
> >>
> >>
> >"file:"
> >
> >Win2k, Xerces from Ant installation, and an unknown version of Xalan
(I've
> >been swapping different versions around on it).
> >
> > Erik
> >
> I will try with the latest 2.3.1
>
> Saxon also has a bug in forming URIs in versions 6.5.0 - 6.5.2, and
> the next version
> 6.5.3 is going to have a fix. In any event, I will put together a
> testing matrix of good and bad versions of
> various parsers, and maybe we can add it to the docs. Even for the
> "bad" versions, there are workarounds.
>
> Regards,
>
> --Craeg
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
Posted by Stefan Bodewig <bo...@apache.org>.
On Sun, 26 May 2002, Erik Hatcher <ja...@ehatchersolutions.com>
wrote:
> From: "Conor MacNeill" <co...@cortexebusiness.com.au>
>
>> 3. Should Xalan be required for bootstrap?
>>
>> No. IMHO, we should keep the bootstrap requirements to an absolute
>> minimum. This needs to be fixed.
>
> Craeg, Conor - could you let me know what needs to be done to fix
> it?
Of course I'm with Conor here 8-)
There are currently two classes that make bootstrap depend on TraX,
XMLCatalog and XSLTProcess - moving XMLCatalog to types.optional would
work, but XSLTProcess is harder to fix.
Note that we've carefully avoided all TraX dependencies in <style> by
inventing XSLTLogger instead of using ErrorLogger directly. We are
not ready to give up the non-trax implementations for <style> yet, so
we better don't make <style> depend on it.
Taking reflection a step further will probably help 8-).
I'll look into this.
Stefan
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
----- Original Message -----
From: "Conor MacNeill" <co...@cortexebusiness.com.au>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Sunday, May 26, 2002 7:40 PM
Subject: Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was:
XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
> 3. Should Xalan be required for bootstrap?
>
> No. IMHO, we should keep the bootstrap requirements to an absolute
> minimum. This needs to be fixed.
Craeg, Conor - could you let me know what needs to be done to fix it? I'll
do what it takes, but I'm merely the middleman for applying Craeg's patch on
this one.
Thanks,
Erik
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java
-- patch breaks bootstrap.bat Yikes!]
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
Craeg K Strong wrote:
> [PROPOSAL]
>
> What about this as an alternative:
>
> 1) replace xmlParserAPIs.jar with xml-apis.jar in lib/
> 2) put xalan.jar in lib/optional
> 3) apply the attached patches to bootstrap.bat, bootstrap.sh,
> build.sh, build.bat, and build.xml
>
> xml-apis.jar seems to be a strict superset of xmlParserAPIs.jar
> That is, it is the same except that it includes the entire JAXP
> rather than xerces' chopped down version.
I agree that (1) would be the simplest fix but I did a quick check with
the latest xalan xml-apis.jar and the xerces xmlParserAPIs.jar in Ant's
CVS and found two classes which are not in xml-apis.jar
Only in temp2/org/xml/sax/helpers: NewInstance.class
Only in temp2/org/w3c/dom/html: HTMLDOMImplementation.class
So, it is not a strict superset.
Not sure that (2) is required
>
> Thoughts?
Unprintable, I'm afraid :-) I'm going to ask on the xalan/xerces list in
a while.
Conor
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java
-- patch breaks bootstrap.bat Yikes!]
Posted by Craeg Strong <cs...@arielpartners.com>.
Hello:
Enclosed please find my updated patch for "build.xml" (in handy
single-patch format :-)
It is a minor change, but with significant goodness:
- TraX dependent code will now _compile_ with only the TraX API present
(obviously it will not _run_ the associated tests unless a TraX
IMPLEMENTATION is present)
Without the patch, classes that USE the TraX API like sitraka and
TraXliaison won't even COMPILE without Xalan present.
This means that you need xalan to build them which is an artificial
limitation.
- Allows TraX dependent tests to be run as long as any TraX-compliant
processor is present in the classpath.
I have tested this out the wazzoo:
Windows 2000 + Java 1.3.1_03
- with no TraX
- with Xalan2 (2.3.1)
- with Saxon (6.5.2)
Red Hat Linux 7.2 + Java 1.3.1_03
- with no TraX
- with Xalan2 (2.3.1)
- with Saxon (6.5.2)
In all six cases, I bootstrapped from scratch, ran a build, then did
"ant test" and ran all of the tests (omitting the ones below).
I did notice some interesting issues, but none relevant to the patch:
- FileUtilsTest fails for me (on Windows 2000 only) in setSetLastModified
- JavaTest hangs for me (on Linux only)
- InitializeClassTest hangs for me (on Linux only)
- on Windows only, saxon must be LAST in the path. I believe this is
because saxon includes all of the JAXP library
in the same jar (not unbundled like xalan) and its JAXP is an earlier
version that has win32 uri-resolver bugs. Michael
Kay has indicated to me in an email that this will be fixed in the next
release.
--Craeg
Erik Hatcher wrote:
>I've committed the changes from Craeg's bootstrap and build patches and
>relocated xml-apis.jar to the lib directory. All is working fine for me
>with, even a full "build test" succeeded.
>
>I'll be glad to help our further if there are still issues that need to be
>addressed, such as more refinements to build.xml as Craeg suggests.
>
> Erik
>
>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
I've committed the changes from Craeg's bootstrap and build patches and
relocated xml-apis.jar to the lib directory. All is working fine for me
with, even a full "build test" succeeded.
I'll be glad to help our further if there are still issues that need to be
addressed, such as more refinements to build.xml as Craeg suggests.
Erik
----- Original Message -----
From: "Craeg K Strong" <cs...@arielpartners.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Monday, May 27, 2002 7:36 PM
Subject: Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was:
XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
> Yep. Just the build.{bat,sh} and bootstrap.{bat,sh}
> If you need an "all in one" patch send me a private email and I will
> recast it as such.
>
> The build.xml situation, however, has changed slightly. I now understand
that
> there should be TWO properties: "trax.present" and "trax.impl.present"
> so I would slighly redo my build.xml patch.
>
> Again, relatively easy assuming we all agree on that approach.
> Let me know... I am happy to help however I can.
>
> --Craeg
>
> Erik Hatcher wrote:
> > I agree.... my first attempt at moving it to lib and removing
> > xmlParserAPIs.jar did not succeed though, but I'm guessing I need to
apply
> > the patches that Craeg sent.
> >
> > Erik
> >
> >
> > ----- Original Message -----
> > From: "Conor MacNeill" <co...@cortexebusiness.com.au>
> > To: "Ant Developers List" <an...@jakarta.apache.org>
> > Sent: Monday, May 27, 2002 8:29 AM
> > Subject: Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was:
> > XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
> >
> >
> >
> >>Erik Hatcher wrote:
> >>
> >>>Adding the xml-apis.jar to lib/optional fixed bootstrap for me, at
> >>
> > least.
> >
> >>which really means it isn't optional :-) Just a note for the longer
term.
> >>junit is in optional because it is only required for testing ant and not
> >
> > for
> >
> >>the main ant build.
> >>
> >>Let's leave it for now but eventually I'd like to see it in lib.
> >>
> >>Conor
> >>
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java
-- patch breaks bootstrap.bat Yikes!]
Posted by Craeg K Strong <cs...@arielpartners.com>.
Yep. Just the build.{bat,sh} and bootstrap.{bat,sh}
If you need an "all in one" patch send me a private email and I will
recast it as such.
The build.xml situation, however, has changed slightly. I now understand that
there should be TWO properties: "trax.present" and "trax.impl.present"
so I would slighly redo my build.xml patch.
Again, relatively easy assuming we all agree on that approach.
Let me know... I am happy to help however I can.
--Craeg
Erik Hatcher wrote:
> I agree.... my first attempt at moving it to lib and removing
> xmlParserAPIs.jar did not succeed though, but I'm guessing I need to apply
> the patches that Craeg sent.
>
> Erik
>
>
> ----- Original Message -----
> From: "Conor MacNeill" <co...@cortexebusiness.com.au>
> To: "Ant Developers List" <an...@jakarta.apache.org>
> Sent: Monday, May 27, 2002 8:29 AM
> Subject: Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was:
> XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
>
>
>
>>Erik Hatcher wrote:
>>
>>>Adding the xml-apis.jar to lib/optional fixed bootstrap for me, at
>>
> least.
>
>>which really means it isn't optional :-) Just a note for the longer term.
>>junit is in optional because it is only required for testing ant and not
>
> for
>
>>the main ant build.
>>
>>Let's leave it for now but eventually I'd like to see it in lib.
>>
>>Conor
>>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
I agree.... my first attempt at moving it to lib and removing
xmlParserAPIs.jar did not succeed though, but I'm guessing I need to apply
the patches that Craeg sent.
Erik
----- Original Message -----
From: "Conor MacNeill" <co...@cortexebusiness.com.au>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Monday, May 27, 2002 8:29 AM
Subject: Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was:
XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
> Erik Hatcher wrote:
> > Adding the xml-apis.jar to lib/optional fixed bootstrap for me, at
least.
>
> which really means it isn't optional :-) Just a note for the longer term.
> junit is in optional because it is only required for testing ant and not
for
> the main ant build.
>
> Let's leave it for now but eventually I'd like to see it in lib.
>
> Conor
>
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java
-- patch breaks bootstrap.bat Yikes!]
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
Erik Hatcher wrote:
> Adding the xml-apis.jar to lib/optional fixed bootstrap for me, at least.
which really means it isn't optional :-) Just a note for the longer term.
junit is in optional because it is only required for testing ant and not for
the main ant build.
Let's leave it for now but eventually I'd like to see it in lib.
Conor
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java
-- patch breaks bootstrap.bat Yikes!]
Posted by Craeg K Strong <cs...@arielpartners.com>.
Erp.. sorry about that! Will do in future.
--Craeg
Erik Hatcher wrote:
> I won't have time to get to this until much later tonight at the earliest,
> but again could you submit patches that you want applied as a unit all
> together in a single patch file? It would be *most* helpful and expedite
> them being applied....
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
I won't have time to get to this until much later tonight at the earliest,
but again could you submit patches that you want applied as a unit all
together in a single patch file? It would be *most* helpful and expedite
them being applied.... unless someone wants to share a trick to applying
multiple patches like this in one shot. I'm simply doing 'patch -p0 <
filename' which requires me to put these patch files in the proper directory
(which is why one patch from the root directory is best for me) and then
change into each directory to apply them manually.
Adding the xml-apis.jar to lib/optional fixed bootstrap for me, at least.
Erik
----- Original Message -----
From: "Craeg K Strong" <cs...@arielpartners.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Monday, May 27, 2002 1:00 AM
Subject: Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was:
XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
> [PROPOSAL]
>
> What about this as an alternative:
>
> 1) replace xmlParserAPIs.jar with xml-apis.jar in lib/
> 2) put xalan.jar in lib/optional
> 3) apply the attached patches to bootstrap.bat, bootstrap.sh,
> build.sh, build.bat, and build.xml
>
> xml-apis.jar seems to be a strict superset of xmlParserAPIs.jar
> That is, it is the same except that it includes the entire JAXP
> rather than xerces' chopped down version.
>
> The patches to bootstrap.{sh,bat} and build.{sh,bat} merely substitute
> xml-apis.jar for xmlParserAPIs.jar
>
> The patch to build.xml modifies the "trax.present" condition so that
> it accurately reports the presence of an _implementation_ of trax, rather
> than the _interface_ of the trax/JAXP API.
>
> Advantages:
>
> - xalan.jar is not required for bootstrapping
> - If you want to execute XsltTest, simply include xalan.jar in your path.
> otherwise it is ommitted
>
> I tried this out on both Windows 2000 and Red Hat Linux 7.2 with
> Java 1.3.1_03 and it seemed to work fine (although some other testcases
> failed for me...?)
>
> Thoughts?
>
> --Craeg
>
> Conor MacNeill wrote:
> > costinm@covalent.net wrote:
> >
> >> On Mon, 27 May 2002, Conor MacNeill wrote:
> >>
> >> There is a section in all JCP specs that (aledgedly) require any
> >> implementation to pass a test suite, otherwise it can't be distributed.
> >> There are also requirements to distribute the full impl, not a subset.
> >> Of course, xerces is a clean-room implementation ( but as it was
> >> discussed, it is not clear if clean-room is ok - and some people who
> >> contributed on the impl. have read the spec ).
> >>
> >> Again, it all depends on how much you care about small prints and
> >> how you want to interpret it. Some believe that are issues with the
> >> parts of the licence that restrict clean-room impl of a spec. And I
doubt
> >> Sun will sue ASF for this.
> >> In any case, distributing Jaxp without Xalan can't be called a
> >> 'JAXP1.1 implementation', and can't pass the test suite ( since
> >> 1/2 tests are for XSLT ).
> >> For an official answer you should contact Sam Ruby, or someone who
> >> have access to the licensing list on ASF. All I can say is that
> >> distributing it without xalan makes me very uncomfortable.
> >
> >
> > OK thanks. IANAL either so the following is just my opinion :-)
> >
> > According to the current JCP requirements I'm not sure we could
> > distribute Ant with either Xerces or Xalan since I am not aware that
> > either pass their JCP test suite (there may be some exemptions
> > negotiated for Apache that I am unaware of). If the press releases were
> > any guide, this issue should be resolved but I don't think the final
> > resolution has happened yet.
> >
> > You know, if what you contend is true, Xerces itself could not be
> > distributed without Xalan :-)
> >
> > If we do decide to include Xalan we need to figure out which xml-apis
> > jar to include since Xerces and Xalan appear to use different versions
> > :-( Can anyone vouch for the suitability of using Xerces with Xalan's
> > xml-apis jar or do we have to take a leap of faith?
> >
> > Conor
> >
>
----------------------------------------------------------------------------
----
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java
-- patch breaks bootstrap.bat Yikes!]
Posted by Craeg K Strong <cs...@arielpartners.com>.
[PROPOSAL]
What about this as an alternative:
1) replace xmlParserAPIs.jar with xml-apis.jar in lib/
2) put xalan.jar in lib/optional
3) apply the attached patches to bootstrap.bat, bootstrap.sh,
build.sh, build.bat, and build.xml
xml-apis.jar seems to be a strict superset of xmlParserAPIs.jar
That is, it is the same except that it includes the entire JAXP
rather than xerces' chopped down version.
The patches to bootstrap.{sh,bat} and build.{sh,bat} merely substitute
xml-apis.jar for xmlParserAPIs.jar
The patch to build.xml modifies the "trax.present" condition so that
it accurately reports the presence of an _implementation_ of trax, rather
than the _interface_ of the trax/JAXP API.
Advantages:
- xalan.jar is not required for bootstrapping
- If you want to execute XsltTest, simply include xalan.jar in your path.
otherwise it is ommitted
I tried this out on both Windows 2000 and Red Hat Linux 7.2 with
Java 1.3.1_03 and it seemed to work fine (although some other testcases
failed for me...?)
Thoughts?
--Craeg
Conor MacNeill wrote:
> costinm@covalent.net wrote:
>
>> On Mon, 27 May 2002, Conor MacNeill wrote:
>>
>> There is a section in all JCP specs that (aledgedly) require any
>> implementation to pass a test suite, otherwise it can't be distributed.
>> There are also requirements to distribute the full impl, not a subset.
>> Of course, xerces is a clean-room implementation ( but as it was
>> discussed, it is not clear if clean-room is ok - and some people who
>> contributed on the impl. have read the spec ).
>>
>> Again, it all depends on how much you care about small prints and
>> how you want to interpret it. Some believe that are issues with the
>> parts of the licence that restrict clean-room impl of a spec. And I doubt
>> Sun will sue ASF for this.
>> In any case, distributing Jaxp without Xalan can't be called a
>> 'JAXP1.1 implementation', and can't pass the test suite ( since
>> 1/2 tests are for XSLT ).
>> For an official answer you should contact Sam Ruby, or someone who
>> have access to the licensing list on ASF. All I can say is that
>> distributing it without xalan makes me very uncomfortable.
>
>
> OK thanks. IANAL either so the following is just my opinion :-)
>
> According to the current JCP requirements I'm not sure we could
> distribute Ant with either Xerces or Xalan since I am not aware that
> either pass their JCP test suite (there may be some exemptions
> negotiated for Apache that I am unaware of). If the press releases were
> any guide, this issue should be resolved but I don't think the final
> resolution has happened yet.
>
> You know, if what you contend is true, Xerces itself could not be
> distributed without Xalan :-)
>
> If we do decide to include Xalan we need to figure out which xml-apis
> jar to include since Xerces and Xalan appear to use different versions
> :-( Can anyone vouch for the suitability of using Xerces with Xalan's
> xml-apis jar or do we have to take a leap of faith?
>
> Conor
>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java
-- patch breaks bootstrap.bat Yikes!]
Posted by co...@covalent.net.
On Mon, 27 May 2002, Conor MacNeill wrote:
> According to the current JCP requirements I'm not sure we could
> distribute Ant with either Xerces or Xalan since I am not aware that
> either pass their JCP test suite (there may be some exemptions
> negotiated for Apache that I am unaware of). If the press releases were
> any guide, this issue should be resolved but I don't think the final
> resolution has happened yet.
That's a question for the PMC, do you know any member ? :-)
Since Xalan is included in the JDK1.4 and is the RI, we can assume it
passed the tests. The question is if distributing 1/2 of a spec
impl. is ok.
I'm not saying it isn't ok, just that we don't know.
> You know, if what you contend is true, Xerces itself could not be
> distributed without Xalan :-)
Good argument.
We can either ignore the problem - probably nobody will notice or
care anyway - or just pass it to Sam. We allways have the choice
of distributing the unmodified reference implementation from Sun
( unfortunately they haven't switched yet to xerces2 )
> If we do decide to include Xalan we need to figure out which xml-apis
> jar to include since Xerces and Xalan appear to use different versions
> :-( Can anyone vouch for the suitability of using Xerces with Xalan's
> xml-apis jar or do we have to take a leap of faith?
I think I can, I worked on this for a while and I'm familiar with the
code.
Costin
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java
-- patch breaks bootstrap.bat Yikes!]
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
costinm@covalent.net wrote:
> On Mon, 27 May 2002, Conor MacNeill wrote:
>
> There is a section in all JCP specs that (aledgedly) require any
> implementation to pass a test suite, otherwise it can't be distributed.
> There are also requirements to distribute the full impl, not a subset.
> Of course, xerces is a clean-room implementation ( but as it was
> discussed, it is not clear if clean-room is ok - and some people who
> contributed on the impl. have read the spec ).
>
> Again, it all depends on how much you care about small prints and
> how you want to interpret it. Some believe that are issues with the parts
> of the licence that restrict clean-room impl of a spec. And I doubt
> Sun will sue ASF for this.
>
> In any case, distributing Jaxp without Xalan can't be called a
> 'JAXP1.1 implementation', and can't pass the test suite ( since
> 1/2 tests are for XSLT ).
>
> For an official answer you should contact Sam Ruby, or someone who
> have access to the licensing list on ASF. All I can say is that
> distributing it without xalan makes me very uncomfortable.
OK thanks. IANAL either so the following is just my opinion :-)
According to the current JCP requirements I'm not sure we could
distribute Ant with either Xerces or Xalan since I am not aware that
either pass their JCP test suite (there may be some exemptions
negotiated for Apache that I am unaware of). If the press releases were
any guide, this issue should be resolved but I don't think the final
resolution has happened yet.
You know, if what you contend is true, Xerces itself could not be
distributed without Xalan :-)
If we do decide to include Xalan we need to figure out which xml-apis
jar to include since Xerces and Xalan appear to use different versions
:-( Can anyone vouch for the suitability of using Xerces with Xalan's
xml-apis jar or do we have to take a leap of faith?
Conor
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java
-- patch breaks bootstrap.bat Yikes!]
Posted by co...@covalent.net.
On Mon, 27 May 2002, Conor MacNeill wrote:
> costinm@covalent.net wrote:
> > If this is a [metoo] thread - including xalan ( or an xslt impl) if you
> > include jaxp.jar is not only nice, but it may be required by the JAXP licence.
> >
>
>
> There seem to be three issues in play here
> 1. Are we *required* to bundle Xalan?
>
> Currently we do not include a full jaxp.jar but that strange cutdown
> Xerces one. Costin, can you give more concrete information on what the
> JAXP licence requires?
There is a section in all JCP specs that (aledgedly) require any
implementation to pass a test suite, otherwise it can't be distributed.
There are also requirements to distribute the full impl, not a subset.
Of course, xerces is a clean-room implementation ( but as it was
discussed, it is not clear if clean-room is ok - and some people who
contributed on the impl. have read the spec ).
Again, it all depends on how much you care about small prints and
how you want to interpret it. Some believe that are issues with the parts
of the licence that restrict clean-room impl of a spec. And I doubt
Sun will sue ASF for this.
In any case, distributing Jaxp without Xalan can't be called a
'JAXP1.1 implementation', and can't pass the test suite ( since
1/2 tests are for XSLT ).
For an official answer you should contact Sam Ruby, or someone who
have access to the licensing list on ASF. All I can say is that
distributing it without xalan makes me very uncomfortable.
( sory for the length - I have no idea how to deal with this kind of
stuff. I've been warned ( by a friendly person ) that only a lawyer
can answer this question properly, and I should be careful to not
missinform people - so add an 'aledeged' or similar before each
word above ).
> 2. Should we bundle Xalan because some people find it useful?
>
> I'm -0 on that question. In general I don't think we should bundle
> everything into an Ant distribution. There are lots of other things we
> could bundle too. Perhaps we could have the Ant mega special - not only
> does it include optional.jar but a selection of other useful Apache jars.
The licence is my main concern. I'm +1 on bundling Xalan - because
it is useful and makes things consistent with JDK1.4 ( where it
part of rt.jar ).
Costin
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java
-- patch breaks bootstrap.bat Yikes!]
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
costinm@covalent.net wrote:
> If this is a [metoo] thread - including xalan ( or an xslt impl) if you
> include jaxp.jar is not only nice, but it may be required by the JAXP licence.
>
There seem to be three issues in play here
1. Are we *required* to bundle Xalan?
Currently we do not include a full jaxp.jar but that strange cutdown
Xerces one. Costin, can you give more concrete information on what the
JAXP licence requires?
2. Should we bundle Xalan because some people find it useful?
I'm -0 on that question. In general I don't think we should bundle
everything into an Ant distribution. There are lots of other things we
could bundle too. Perhaps we could have the Ant mega special - not only
does it include optional.jar but a selection of other useful Apache jars.
3. Should Xalan be required for bootstrap?
No. IMHO, we should keep the bootstrap requirements to an absolute
minimum. This needs to be fixed.
Conor
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java
-- patch breaks bootstrap.bat Yikes!]
Posted by co...@covalent.net.
If this is a [metoo] thread - including xalan ( or an xslt impl) if you
include jaxp.jar is not only nice, but it may be required by the JAXP licence.
Costin
On Sun, 26 May 2002, Peter Donald wrote:
>
> +1
> Me too! But you knew that ;)
>
> On Sat, 25 May 2002 09:19, Erik Hatcher wrote:
> > Like I said, I'm +1 on including Xalan simply because it makes the tasks I
> > use frequently automatically work with no other configuration/installation.
> >
> > Erik
> >
> >
> > ----- Original Message -----
> > From: "Craeg Strong" <cs...@arielpartners.com>
> > To: "Erik Hatcher" <ja...@ehatchersolutions.com>;
> > <an...@jakarta.apache.org>
> > Sent: Friday, May 24, 2002 8:54 PM
> > Subject: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java --
> > patch breaks bootstrap.bat Yikes!]
> >
> > > Hello:
> > >
> > > I have found the thread where the choice of JAXP/xerces/xalan jar files
> > > to include in Ant 1.5 was discussed:
> > >
> > > http://marc.theaimsgroup.com/?t=101838850500001&r=1&w=2
> > >
> > > Stefan Bodewig was the one who expressed reservations about including
> > > the Xalan jar files,
> > > but he did not explicitly veto the idea. His concern [ Stefan correct
> > > me if I am wrong here ] is that
> > > we should minimize the number of third party jar files that we ship with
> > > b/c then you
> > > have the problem that they get out of date-- right? Each of the
> > > respective Apache projects:
> > > Ant, Xerces, and Xalan are on different release schedules, so by only
> > > including _absolutely necessary_ jar files,
> > > you minimize the problem.
> > >
> > > Here is my take on the issue. Ant release 1.4.1 INCLUDES jaxp.jar
> > > That means that my new "XMLCatalog.java" code
> > > compiles just fine using Ant 1.4.1
> > >
> > > By removing jaxp.jar from the bootstrap class path in 1.5, we have
> > > REMOVED APIs that used to be there. My code was
> > > simply the first place to demonstrate this fact. There is no telling
> > > what ELSE we might break. For example,
> > > third party tasks that used to compile now won't, etc.
> > >
> > > Because "jaxp.jar" _was already_ a part of Ant release 1.4.1, I think
> > > the easiest, quickest, and most conservative approach
> > > is simply to put it back.
> > >
> > > As far as I know, all that would be required is to add it back to the
> > > classpath in "boostrap.bat", "bootstrap.sh", "build.bat", and "build.sh"
> > >
> > > Otherwise, I would be even happier if this provided the impetus for
> > > bundling Xalan with Ant as well. Then I believe all we would need
> > > would be "xercesImpl.jar", "xml-apis.jar" and "xalan.jar" (xml-apis.jar
> > > obviates both jaxp.jar and xmlParserAPIs.jar, right?)
> > >
> > > Erik, Stefan, Magesh-- what do you think?
> > >
> > > --Craeg
> > >
> > > Erik Hatcher wrote:
> > > >Yikes! I was concerned about that when I saw the additional imports,
> > > > but because I have Xalan in my bootstrap classpath it worked I guess.
> > > >
> > > >I +1'd including Xalan as its such a fundamental piece to things like
> > > ><junitreport> and <xslt> - but I think at least one committer veto'd it?
> >
> > I
> >
> > > >still support including it.
> > > >
> > > > Erik
> > > >
> > > >>Hello:
> > > >>
> > > >>Responses to previous email are down below, but a bigger issue has come
> > > >>up.
> > > >>
> > > >>I never realized until this very moment that the xmlParserAPIs.jar that
> > > >>comes with
> > > >>Xerces does __NOT__ contain the full JAXP library. Instead, they
> > > >>chopped it in half
> > > >>and only included the pieces that are actually implemented by xerces.
> > > >>This is bad.
> > > >>
> > > >>XMLCatalog as I have now modified it makes use of the OTHER pieces of
> > > >>the JAXP library,
> > > >>although it does NOT require actual implementations of the Transformer
> > > >>classes
> > > >>(that is, neither Xalan nor Saxon have to be on the path).
> > > >>
> > > >>The problem is, bootstrap.bat / boostrap.sh FAIL to build Ant now
> > > >>because of the missing
> > > >>APIs. >:-(
> > > >>
> > > >>What is the best way to fix this? I remember there was some
> > > >>discussion about including
> > > >>the xalan jar files in Ant/lib: xalan.jar and xml-api.jar
> > > >>
> > > >>Of course, the Xalan xml-api.jar includes the ENTIRE jaxp library, so
> > > >>there would be
> > > >>considerable overlap with xerces xmlParserAPIs.jar
> > > >>
> > > >>Another alternative is to include jaxp.jar from JAXP 1.1 At only
> >
> > 28K,
> >
> > > >>it does not add much to the size of the ant download.
> > > >>
> > > >>Again, however, there would be some overlap with the xerces
> > > >>xmlParserAPIs.jar
> > > >>
> > > >>Anyway, it seems pretty reasonable to me that Ant would include a
> > > >>jaxp.jar library,
> > > >>as it is intrinsically dependent on much of JAXP. Otherwise, we would
> > > >>have to do something
> > > >>horribly ugly like breaking up XMLCatalog into two pieces. yuk.
> > > >>
> > > >>Thoughts?
> > > >>
> > > >>--Craeg
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
Posted by Peter Donald <pe...@apache.org>.
+1
Me too! But you knew that ;)
On Sat, 25 May 2002 09:19, Erik Hatcher wrote:
> Like I said, I'm +1 on including Xalan simply because it makes the tasks I
> use frequently automatically work with no other configuration/installation.
>
> Erik
>
>
> ----- Original Message -----
> From: "Craeg Strong" <cs...@arielpartners.com>
> To: "Erik Hatcher" <ja...@ehatchersolutions.com>;
> <an...@jakarta.apache.org>
> Sent: Friday, May 24, 2002 8:54 PM
> Subject: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java --
> patch breaks bootstrap.bat Yikes!]
>
> > Hello:
> >
> > I have found the thread where the choice of JAXP/xerces/xalan jar files
> > to include in Ant 1.5 was discussed:
> >
> > http://marc.theaimsgroup.com/?t=101838850500001&r=1&w=2
> >
> > Stefan Bodewig was the one who expressed reservations about including
> > the Xalan jar files,
> > but he did not explicitly veto the idea. His concern [ Stefan correct
> > me if I am wrong here ] is that
> > we should minimize the number of third party jar files that we ship with
> > b/c then you
> > have the problem that they get out of date-- right? Each of the
> > respective Apache projects:
> > Ant, Xerces, and Xalan are on different release schedules, so by only
> > including _absolutely necessary_ jar files,
> > you minimize the problem.
> >
> > Here is my take on the issue. Ant release 1.4.1 INCLUDES jaxp.jar
> > That means that my new "XMLCatalog.java" code
> > compiles just fine using Ant 1.4.1
> >
> > By removing jaxp.jar from the bootstrap class path in 1.5, we have
> > REMOVED APIs that used to be there. My code was
> > simply the first place to demonstrate this fact. There is no telling
> > what ELSE we might break. For example,
> > third party tasks that used to compile now won't, etc.
> >
> > Because "jaxp.jar" _was already_ a part of Ant release 1.4.1, I think
> > the easiest, quickest, and most conservative approach
> > is simply to put it back.
> >
> > As far as I know, all that would be required is to add it back to the
> > classpath in "boostrap.bat", "bootstrap.sh", "build.bat", and "build.sh"
> >
> > Otherwise, I would be even happier if this provided the impetus for
> > bundling Xalan with Ant as well. Then I believe all we would need
> > would be "xercesImpl.jar", "xml-apis.jar" and "xalan.jar" (xml-apis.jar
> > obviates both jaxp.jar and xmlParserAPIs.jar, right?)
> >
> > Erik, Stefan, Magesh-- what do you think?
> >
> > --Craeg
> >
> > Erik Hatcher wrote:
> > >Yikes! I was concerned about that when I saw the additional imports,
> > > but because I have Xalan in my bootstrap classpath it worked I guess.
> > >
> > >I +1'd including Xalan as its such a fundamental piece to things like
> > ><junitreport> and <xslt> - but I think at least one committer veto'd it?
>
> I
>
> > >still support including it.
> > >
> > > Erik
> > >
> > >>Hello:
> > >>
> > >>Responses to previous email are down below, but a bigger issue has come
> > >>up.
> > >>
> > >>I never realized until this very moment that the xmlParserAPIs.jar that
> > >>comes with
> > >>Xerces does __NOT__ contain the full JAXP library. Instead, they
> > >>chopped it in half
> > >>and only included the pieces that are actually implemented by xerces.
> > >>This is bad.
> > >>
> > >>XMLCatalog as I have now modified it makes use of the OTHER pieces of
> > >>the JAXP library,
> > >>although it does NOT require actual implementations of the Transformer
> > >>classes
> > >>(that is, neither Xalan nor Saxon have to be on the path).
> > >>
> > >>The problem is, bootstrap.bat / boostrap.sh FAIL to build Ant now
> > >>because of the missing
> > >>APIs. >:-(
> > >>
> > >>What is the best way to fix this? I remember there was some
> > >>discussion about including
> > >>the xalan jar files in Ant/lib: xalan.jar and xml-api.jar
> > >>
> > >>Of course, the Xalan xml-api.jar includes the ENTIRE jaxp library, so
> > >>there would be
> > >>considerable overlap with xerces xmlParserAPIs.jar
> > >>
> > >>Another alternative is to include jaxp.jar from JAXP 1.1 At only
>
> 28K,
>
> > >>it does not add much to the size of the ant download.
> > >>
> > >>Again, however, there would be some overlap with the xerces
> > >>xmlParserAPIs.jar
> > >>
> > >>Anyway, it seems pretty reasonable to me that Ant would include a
> > >>jaxp.jar library,
> > >>as it is intrinsically dependent on much of JAXP. Otherwise, we would
> > >>have to do something
> > >>horribly ugly like breaking up XMLCatalog into two pieces. yuk.
> > >>
> > >>Thoughts?
> > >>
> > >>--Craeg
--
Cheers,
Peter Donald
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
Duh..... thanks.
----- Original Message -----
From: "Steve Loughran" <st...@iseran.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Saturday, May 25, 2002 2:08 PM
Subject: Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was:
XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
>
> ----- Original Message -----
> From: "Erik Hatcher" <ja...@ehatchersolutions.com>
> To: "Ant Developers List" <an...@jakarta.apache.org>
> Sent: Saturday, May 25, 2002 9:20 AM
> Subject: Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was:
> XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
>
>
> > Bootstrap worked from Gump last night:
> >
> > http://jakarta.apache.org/builds/gump/latest/bootstrap-ant.html
> >
> > Stefan? Did you adjust it to work? Or did it already include JAXP?
> >
> > What should we do so that bootstrap works from CVS though?
> >
> > Erik
>
>
> GUMP builds CVS_HEAD, not ANT_15_BRANCH, remember? Nothing has broken
there
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
Posted by Steve Loughran <st...@iseran.com>.
----- Original Message -----
From: "Erik Hatcher" <ja...@ehatchersolutions.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Saturday, May 25, 2002 9:20 AM
Subject: Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was:
XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
> Bootstrap worked from Gump last night:
>
> http://jakarta.apache.org/builds/gump/latest/bootstrap-ant.html
>
> Stefan? Did you adjust it to work? Or did it already include JAXP?
>
> What should we do so that bootstrap works from CVS though?
>
> Erik
GUMP builds CVS_HEAD, not ANT_15_BRANCH, remember? Nothing has broken there
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
Posted by Stefan Bodewig <bo...@apache.org>.
On Sat, 25 May 2002, Erik Hatcher <ja...@ehatchersolutions.com>
wrote:
> Bootstrap worked from Gump last night:
Gump uses HEAD, not the 1.5 branch. *My* Gump uses 1.5 and fails
badly.
Stefan
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
Bootstrap worked from Gump last night:
http://jakarta.apache.org/builds/gump/latest/bootstrap-ant.html
Stefan? Did you adjust it to work? Or did it already include JAXP?
What should we do so that bootstrap works from CVS though?
Erik
----- Original Message -----
From: "Erik Hatcher" <ja...@ehatchersolutions.com>
To: "Craeg Strong" <cs...@arielpartners.com>; <an...@jakarta.apache.org>
Sent: Friday, May 24, 2002 7:19 PM
Subject: Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was:
XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
> Like I said, I'm +1 on including Xalan simply because it makes the tasks I
> use frequently automatically work with no other
configuration/installation.
>
> Erik
>
>
> ----- Original Message -----
> From: "Craeg Strong" <cs...@arielpartners.com>
> To: "Erik Hatcher" <ja...@ehatchersolutions.com>;
> <an...@jakarta.apache.org>
> Sent: Friday, May 24, 2002 8:54 PM
> Subject: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was:
XMLCatalog.java --
> patch breaks bootstrap.bat Yikes!]
>
>
> > Hello:
> >
> > I have found the thread where the choice of JAXP/xerces/xalan jar files
> > to include in Ant 1.5 was discussed:
> >
> > http://marc.theaimsgroup.com/?t=101838850500001&r=1&w=2
> >
> > Stefan Bodewig was the one who expressed reservations about including
> > the Xalan jar files,
> > but he did not explicitly veto the idea. His concern [ Stefan correct
> > me if I am wrong here ] is that
> > we should minimize the number of third party jar files that we ship with
> > b/c then you
> > have the problem that they get out of date-- right? Each of the
> > respective Apache projects:
> > Ant, Xerces, and Xalan are on different release schedules, so by only
> > including _absolutely necessary_ jar files,
> > you minimize the problem.
> >
> > Here is my take on the issue. Ant release 1.4.1 INCLUDES jaxp.jar
> > That means that my new "XMLCatalog.java" code
> > compiles just fine using Ant 1.4.1
> >
> > By removing jaxp.jar from the bootstrap class path in 1.5, we have
> > REMOVED APIs that used to be there. My code was
> > simply the first place to demonstrate this fact. There is no telling
> > what ELSE we might break. For example,
> > third party tasks that used to compile now won't, etc.
> >
> > Because "jaxp.jar" _was already_ a part of Ant release 1.4.1, I think
> > the easiest, quickest, and most conservative approach
> > is simply to put it back.
> >
> > As far as I know, all that would be required is to add it back to the
> > classpath in "boostrap.bat", "bootstrap.sh", "build.bat", and "build.sh"
> >
> > Otherwise, I would be even happier if this provided the impetus for
> > bundling Xalan with Ant as well. Then I believe all we would need
> > would be "xercesImpl.jar", "xml-apis.jar" and "xalan.jar" (xml-apis.jar
> > obviates both jaxp.jar and xmlParserAPIs.jar, right?)
> >
> > Erik, Stefan, Magesh-- what do you think?
> >
> > --Craeg
> >
> > Erik Hatcher wrote:
> >
> > >Yikes! I was concerned about that when I saw the additional imports,
but
> > >because I have Xalan in my bootstrap classpath it worked I guess.
> > >
> > >I +1'd including Xalan as its such a fundamental piece to things like
> > ><junitreport> and <xslt> - but I think at least one committer veto'd
it?
> I
> > >still support including it.
> > >
> > > Erik
> > >
> > >>Hello:
> > >>
> > >>Responses to previous email are down below, but a bigger issue has
come
> > >>up.
> > >>
> > >>I never realized until this very moment that the xmlParserAPIs.jar
that
> > >>comes with
> > >>Xerces does __NOT__ contain the full JAXP library. Instead, they
> > >>chopped it in half
> > >>and only included the pieces that are actually implemented by xerces.
> > >>This is bad.
> > >>
> > >>XMLCatalog as I have now modified it makes use of the OTHER pieces of
> > >>the JAXP library,
> > >>although it does NOT require actual implementations of the Transformer
> > >>classes
> > >>(that is, neither Xalan nor Saxon have to be on the path).
> > >>
> > >>The problem is, bootstrap.bat / boostrap.sh FAIL to build Ant now
> > >>because of the missing
> > >>APIs. >:-(
> > >>
> > >>What is the best way to fix this? I remember there was some
> > >>discussion about including
> > >>the xalan jar files in Ant/lib: xalan.jar and xml-api.jar
> > >>
> > >>Of course, the Xalan xml-api.jar includes the ENTIRE jaxp library, so
> > >>there would be
> > >>considerable overlap with xerces xmlParserAPIs.jar
> > >>
> > >>Another alternative is to include jaxp.jar from JAXP 1.1 At only
> 28K,
> > >>it does not add much to the size of the ant download.
> > >>
> > >>Again, however, there would be some overlap with the xerces
> > >>xmlParserAPIs.jar
> > >>
> > >>Anyway, it seems pretty reasonable to me that Ant would include a
> > >>jaxp.jar library,
> > >>as it is intrinsically dependent on much of JAXP. Otherwise, we
would
> > >>have to do something
> > >>horribly ugly like breaking up XMLCatalog into two pieces. yuk.
> > >>
> > >>Thoughts?
> > >>
> > >>--Craeg
> > >>
> > >>
> >
> >
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!]
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
Like I said, I'm +1 on including Xalan simply because it makes the tasks I
use frequently automatically work with no other configuration/installation.
Erik
----- Original Message -----
From: "Craeg Strong" <cs...@arielpartners.com>
To: "Erik Hatcher" <ja...@ehatchersolutions.com>;
<an...@jakarta.apache.org>
Sent: Friday, May 24, 2002 8:54 PM
Subject: [IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java --
patch breaks bootstrap.bat Yikes!]
> Hello:
>
> I have found the thread where the choice of JAXP/xerces/xalan jar files
> to include in Ant 1.5 was discussed:
>
> http://marc.theaimsgroup.com/?t=101838850500001&r=1&w=2
>
> Stefan Bodewig was the one who expressed reservations about including
> the Xalan jar files,
> but he did not explicitly veto the idea. His concern [ Stefan correct
> me if I am wrong here ] is that
> we should minimize the number of third party jar files that we ship with
> b/c then you
> have the problem that they get out of date-- right? Each of the
> respective Apache projects:
> Ant, Xerces, and Xalan are on different release schedules, so by only
> including _absolutely necessary_ jar files,
> you minimize the problem.
>
> Here is my take on the issue. Ant release 1.4.1 INCLUDES jaxp.jar
> That means that my new "XMLCatalog.java" code
> compiles just fine using Ant 1.4.1
>
> By removing jaxp.jar from the bootstrap class path in 1.5, we have
> REMOVED APIs that used to be there. My code was
> simply the first place to demonstrate this fact. There is no telling
> what ELSE we might break. For example,
> third party tasks that used to compile now won't, etc.
>
> Because "jaxp.jar" _was already_ a part of Ant release 1.4.1, I think
> the easiest, quickest, and most conservative approach
> is simply to put it back.
>
> As far as I know, all that would be required is to add it back to the
> classpath in "boostrap.bat", "bootstrap.sh", "build.bat", and "build.sh"
>
> Otherwise, I would be even happier if this provided the impetus for
> bundling Xalan with Ant as well. Then I believe all we would need
> would be "xercesImpl.jar", "xml-apis.jar" and "xalan.jar" (xml-apis.jar
> obviates both jaxp.jar and xmlParserAPIs.jar, right?)
>
> Erik, Stefan, Magesh-- what do you think?
>
> --Craeg
>
> Erik Hatcher wrote:
>
> >Yikes! I was concerned about that when I saw the additional imports, but
> >because I have Xalan in my bootstrap classpath it worked I guess.
> >
> >I +1'd including Xalan as its such a fundamental piece to things like
> ><junitreport> and <xslt> - but I think at least one committer veto'd it?
I
> >still support including it.
> >
> > Erik
> >
> >>Hello:
> >>
> >>Responses to previous email are down below, but a bigger issue has come
> >>up.
> >>
> >>I never realized until this very moment that the xmlParserAPIs.jar that
> >>comes with
> >>Xerces does __NOT__ contain the full JAXP library. Instead, they
> >>chopped it in half
> >>and only included the pieces that are actually implemented by xerces.
> >>This is bad.
> >>
> >>XMLCatalog as I have now modified it makes use of the OTHER pieces of
> >>the JAXP library,
> >>although it does NOT require actual implementations of the Transformer
> >>classes
> >>(that is, neither Xalan nor Saxon have to be on the path).
> >>
> >>The problem is, bootstrap.bat / boostrap.sh FAIL to build Ant now
> >>because of the missing
> >>APIs. >:-(
> >>
> >>What is the best way to fix this? I remember there was some
> >>discussion about including
> >>the xalan jar files in Ant/lib: xalan.jar and xml-api.jar
> >>
> >>Of course, the Xalan xml-api.jar includes the ENTIRE jaxp library, so
> >>there would be
> >>considerable overlap with xerces xmlParserAPIs.jar
> >>
> >>Another alternative is to include jaxp.jar from JAXP 1.1 At only
28K,
> >>it does not add much to the size of the ant download.
> >>
> >>Again, however, there would be some overlap with the xerces
> >>xmlParserAPIs.jar
> >>
> >>Anyway, it seems pretty reasonable to me that Ant would include a
> >>jaxp.jar library,
> >>as it is intrinsically dependent on much of JAXP. Otherwise, we would
> >>have to do something
> >>horribly ugly like breaking up XMLCatalog into two pieces. yuk.
> >>
> >>Thoughts?
> >>
> >>--Craeg
> >>
> >>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
[IMPORTANT!] Fix Ant 1.5 Support for JAXP [Was: XMLCatalog.java
-- patch breaks bootstrap.bat Yikes!]
Posted by Craeg Strong <cs...@arielpartners.com>.
Hello:
I have found the thread where the choice of JAXP/xerces/xalan jar files
to include in Ant 1.5 was discussed:
http://marc.theaimsgroup.com/?t=101838850500001&r=1&w=2
Stefan Bodewig was the one who expressed reservations about including
the Xalan jar files,
but he did not explicitly veto the idea. His concern [ Stefan correct
me if I am wrong here ] is that
we should minimize the number of third party jar files that we ship with
b/c then you
have the problem that they get out of date-- right? Each of the
respective Apache projects:
Ant, Xerces, and Xalan are on different release schedules, so by only
including _absolutely necessary_ jar files,
you minimize the problem.
Here is my take on the issue. Ant release 1.4.1 INCLUDES jaxp.jar
That means that my new "XMLCatalog.java" code
compiles just fine using Ant 1.4.1
By removing jaxp.jar from the bootstrap class path in 1.5, we have
REMOVED APIs that used to be there. My code was
simply the first place to demonstrate this fact. There is no telling
what ELSE we might break. For example,
third party tasks that used to compile now won't, etc.
Because "jaxp.jar" _was already_ a part of Ant release 1.4.1, I think
the easiest, quickest, and most conservative approach
is simply to put it back.
As far as I know, all that would be required is to add it back to the
classpath in "boostrap.bat", "bootstrap.sh", "build.bat", and "build.sh"
Otherwise, I would be even happier if this provided the impetus for
bundling Xalan with Ant as well. Then I believe all we would need
would be "xercesImpl.jar", "xml-apis.jar" and "xalan.jar" (xml-apis.jar
obviates both jaxp.jar and xmlParserAPIs.jar, right?)
Erik, Stefan, Magesh-- what do you think?
--Craeg
Erik Hatcher wrote:
>Yikes! I was concerned about that when I saw the additional imports, but
>because I have Xalan in my bootstrap classpath it worked I guess.
>
>I +1'd including Xalan as its such a fundamental piece to things like
><junitreport> and <xslt> - but I think at least one committer veto'd it? I
>still support including it.
>
> Erik
>
>>Hello:
>>
>>Responses to previous email are down below, but a bigger issue has come
>>up.
>>
>>I never realized until this very moment that the xmlParserAPIs.jar that
>>comes with
>>Xerces does __NOT__ contain the full JAXP library. Instead, they
>>chopped it in half
>>and only included the pieces that are actually implemented by xerces.
>>This is bad.
>>
>>XMLCatalog as I have now modified it makes use of the OTHER pieces of
>>the JAXP library,
>>although it does NOT require actual implementations of the Transformer
>>classes
>>(that is, neither Xalan nor Saxon have to be on the path).
>>
>>The problem is, bootstrap.bat / boostrap.sh FAIL to build Ant now
>>because of the missing
>>APIs. >:-(
>>
>>What is the best way to fix this? I remember there was some
>>discussion about including
>>the xalan jar files in Ant/lib: xalan.jar and xml-api.jar
>>
>>Of course, the Xalan xml-api.jar includes the ENTIRE jaxp library, so
>>there would be
>>considerable overlap with xerces xmlParserAPIs.jar
>>
>>Another alternative is to include jaxp.jar from JAXP 1.1 At only 28K,
>>it does not add much to the size of the ant download.
>>
>>Again, however, there would be some overlap with the xerces
>>xmlParserAPIs.jar
>>
>>Anyway, it seems pretty reasonable to me that Ant would include a
>>jaxp.jar library,
>>as it is intrinsically dependent on much of JAXP. Otherwise, we would
>>have to do something
>>horribly ugly like breaking up XMLCatalog into two pieces. yuk.
>>
>>Thoughts?
>>
>>--Craeg
>>
>>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: XMLCatalog.java -- patch breaks bootstrap.bat Yikes!
Posted by Craeg Strong <cs...@arielpartners.com>.
Hello:
Responses to previous email are down below, but a bigger issue has come
up.
I never realized until this very moment that the xmlParserAPIs.jar that
comes with
Xerces does __NOT__ contain the full JAXP library. Instead, they
chopped it in half
and only included the pieces that are actually implemented by xerces.
This is bad.
XMLCatalog as I have now modified it makes use of the OTHER pieces of
the JAXP library,
although it does NOT require actual implementations of the Transformer
classes
(that is, neither Xalan nor Saxon have to be on the path).
The problem is, bootstrap.bat / boostrap.sh FAIL to build Ant now
because of the missing
APIs. >:-(
What is the best way to fix this? I remember there was some
discussion about including
the xalan jar files in Ant/lib: xalan.jar and xml-api.jar
Of course, the Xalan xml-api.jar includes the ENTIRE jaxp library, so
there would be
considerable overlap with xerces xmlParserAPIs.jar
Another alternative is to include jaxp.jar from JAXP 1.1 At only 28K,
it does not add much to the size of the ant download.
Again, however, there would be some overlap with the xerces
xmlParserAPIs.jar
Anyway, it seems pretty reasonable to me that Ant would include a
jaxp.jar library,
as it is intrinsically dependent on much of JAXP. Otherwise, we would
have to do something
horribly ugly like breaking up XMLCatalog into two pieces. yuk.
Thoughts?
--Craeg
Erik Hatcher wrote:
>Craeg,
>
>Ok, I've applied your fix-up patch.
>
Thanks!
>
>
>
>>I am guessing you are using the following:
>>
>>Windows 2000
>>Apache Xerces 2.0.1 (the one that comes bundled with Ant)
>>Apache Xalan 2.3.1
>>
>>Please let me know as soon as possible. I noted in your comments, the
>>
>>
>assert
>
>
>>failures were all of the nature
>>
>>Expected "file:/C:/ant1.5Beta/jakarta-ant/src.../doc.dtd"
>>But Was: "file:C:/ant1.5Beta/jakarta-ant/src.../doc.dtd"
>>
>>That is, the URL was being formed improperly-- missing the slash after
>>
>>
>"file:"
>
>Win2k, Xerces from Ant installation, and an unknown version of Xalan (I've
>been swapping different versions around on it).
>
> Erik
>
I will try with the latest 2.3.1
Saxon also has a bug in forming URIs in versions 6.5.0 - 6.5.2, and
the next version
6.5.3 is going to have a fix. In any event, I will put together a
testing matrix of good and bad versions of
various parsers, and maybe we can add it to the docs. Even for the
"bad" versions, there are workarounds.
Regards,
--Craeg
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: XMLCatalog.java -- commit missed a smidgen.. and test failure questions
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
Craeg,
Ok, I've applied your fix-up patch.
> I am guessing you are using the following:
>
> Windows 2000
> Apache Xerces 2.0.1 (the one that comes bundled with Ant)
> Apache Xalan 2.3.1
>
> Please let me know as soon as possible. I noted in your comments, the
assert
> failures were all of the nature
>
> Expected "file:/C:/ant1.5Beta/jakarta-ant/src.../doc.dtd"
> But Was: "file:C:/ant1.5Beta/jakarta-ant/src.../doc.dtd"
>
> That is, the URL was being formed improperly-- missing the slash after
"file:"
Win2k, Xerces from Ant installation, and an unknown version of Xalan (I've
been swapping different versions around on it).
Erik
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: XMLCatalog.java -- commit missed a smidgen.. and test failure
questions
Posted by Craeg K Strong <cs...@arielpartners.com>.
Darn it, I keep forgetting to zip my patches... :-}
--Craeg
Craeg K Strong wrote:
> Erik:
>
> Thanks very much for committing my (jumbo) patch!
>
> There was still a tiny bit missing from the header comment of
> XMLCatalog.java, plus I removed a typo or two (mine) in the rest. The
> attached patch should do it. The patch is _only_ to code comments.
> All of the source code looks fine.
>
> The test failures, however, are really interesting! I will look into
> them in detail, but I need to know your configuration in order to
> reproduce the problem.
> I am guessing you are using the following:
>
> Windows 2000
> Apache Xerces 2.0.1 (the one that comes bundled with Ant)
> Apache Xalan 2.3.1
>
> Please let me know as soon as possible. I noted in your comments, the
> assert failures were all of the nature
>
> Expected "file:/C:/ant1.5Beta/jakarta-ant/src.../doc.dtd"
> But Was: "file:C:/ant1.5Beta/jakarta-ant/src.../doc.dtd"
>
> That is, the URL was being formed improperly-- missing the slash after
> "file:"
>
> I will find the bug.
> Either it is an Ant issue, in which case I will submit a patch fix, or
> it is a Xalan issue, in which case I will submit a patch workaround.
>
> Regards,
>
> --Craeg
>
>
> ehatcher@apache.org wrote:
>
>> ehatcher 02/05/24 10:40:23
>>
>> Modified: src/main/org/apache/tools/ant/types Tag: ANT_15_BRANCH
>> XMLCatalog.java
>> Log:
>> oops.... the patch I previously applied missed the first "chunk". i
>> think i've got it all fixed now.
>> Revision Changes Path
>> No revision
>> No revision
>> 1.9.2.3 +31 -4
>> jakarta-ant/src/main/org/apache/tools/ant/types/XMLCatalog.java
>> Index: XMLCatalog.java
>> ===================================================================
>> RCS file:
>> /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/types/XMLCatalog.java,v
>>
>> retrieving revision 1.9.2.2
>> retrieving revision 1.9.2.3
>> diff -u -r1.9.2.2 -r1.9.2.3
>> --- XMLCatalog.java 24 May 2002 15:47:56 -0000 1.9.2.2
>> +++ XMLCatalog.java 24 May 2002 17:40:23 -0000 1.9.2.3
>> @@ -101,14 +101,31 @@
>> * the XMLCatalog object and must be labeled <code>dtd</code> and
>> * <code>entity</code> respectively.</p>
>> *
>> - * <p>Possible future extension could allow a catalog file instead
>> of nested
>> - * elements, or use Norman Walsh's entity resolver from
>> xml-commons</p>
>> + * <p>The following is a description of the resolution algorithm:
>> + * entities/URIs/dtds are looked up in each of the following contexts,
>> + * stopping when a valid and readable resource is found:
>> + * <ol>
>
>
> ...
>
>
> ------------------------------------------------------------------------
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
Craeg K Strong, General Partner
Ariel Partners LLC
http://www.arielpartners.com
voice 781-647-2425
fax 781-647-9690
NOTICE: This message is for the sole use of the intended recipient(s)
and may contain confidential and privileged information. Any review,
retransmission, dissemination or other use of, or taking of any action
in reliance upon, this information by persons or entities other than
the intended recipient is prohibited. If you are not the intended
recipient, please contact the sender by reply email and destroy all
copies -- including electronic copies -- of the original message.