[GitHub] [inlong] healchow commented on a diff in pull request #5960: [INLONG-5955][Sort] Support metric state recovery for hbase

[GitBox <gi...@apache.org>]

healchow commented on code in PR #5960:
URL: https://github.com/apache/inlong/pull/5960#discussion_r975036580


##########
inlong-sort/sort-connectors/hbase/src/main/java/org/apache/inlong/sort/hbase/sink/HBaseSinkFunction.java:
##########
@@ -290,11 +303,26 @@ public void snapshotState(FunctionSnapshotContext context) throws Exception {
         while (numPendingRequests.get() != 0) {
             flush();
         }
+        if (sinkMetricData != null && metricStateListState != null) {
+            MetricStateUtils.snapshotMetricStateForSinkMetricData(metricStateListState, sinkMetricData,
+                    getRuntimeContext().getIndexOfThisSubtask());
+        }
     }
 
     @Override
     public void initializeState(FunctionInitializationContext context) throws Exception {
         // nothing to do.

Review Comment:
   This comment seems not needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org