You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/17 01:42:33 UTC
[GitHub] williaster opened a new pull request #5652: [sqllab] call out
transient state of tabs to users
williaster opened a new pull request #5652: [sqllab] call out transient state of tabs to users
URL: https://github.com/apache/incubator-superset/pull/5652
The recent global notifications refactor (#5355) changed redux state such that users lost their SQL lab tabs.
We realized it's not necessarily clear to users that this state is transient (as it currently is implemented with local storage) so we wanted to add a note in the empty tab:
<img width="700" src="https://user-images.githubusercontent.com/4496521/44243451-00719980-a184-11e8-8230-1255a69b0f2e.png">
I have prettier ✨ enabled in my IDE so there are some auto-format changes from that.
@kristw @john-bodley @michellethomas @graceguo-supercat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org