You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "zhangxiangyang (via GitHub)" <gi...@apache.org> on 2023/02/02 01:25:41 UTC
[GitHub] [incubator-streampark] zhangxiangyang opened a new pull request, #2288: [Optimize] streampark.sh starts adding debug mode
zhangxiangyang opened a new pull request, #2288:
URL: https://github.com/apache/incubator-streampark/pull/2288
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
Issue Number: close #xxx <!-- REMOVE this line if no issue to close -->
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added integration tests for end-to-end.*
- *Added *Test to verify the change.*
- *Manually verified the change by testing locally.* -->
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): (yes / no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2288: [Optimize] streampark.sh starts adding debug mode
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2288:
URL: https://github.com/apache/incubator-streampark/pull/2288#issuecomment-1413039094
hi zhangxiangyang:
Thanks for your contribution. Usually, before submit a feature, there will be an "issue" first, describing the background and motivation clearly. I saw that the "debug" mode was added to this pr, also need to be added documentation. It will be smoother to have a good communication with the community
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] zhangxiangyang commented on a diff in pull request #2288: [Feature][Issue-2292] streampark.sh starts adding debug mode
Posted by "zhangxiangyang (via GitHub)" <gi...@apache.org>.
zhangxiangyang commented on code in PR #2288:
URL: https://github.com/apache/incubator-streampark/pull/2288#discussion_r1095520537
##########
streampark-console/streampark-console-service/src/main/assembly/bin/streampark.sh:
##########
@@ -68,6 +68,20 @@ else
RESET=""
fi
+JAVA_OPTS="""
+ $vmOption
Review Comment:
> Why do you move the position of `JAVA_OPTS`? , this will be `vmOption` variable is empty
This problem has been fixed. Please review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys merged pull request #2288: [Feature][Issue-2292] streampark.sh starts adding debug mode
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #2288:
URL: https://github.com/apache/incubator-streampark/pull/2288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2288: [Feature][Issue-2292] streampark.sh starts adding debug mode
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #2288:
URL: https://github.com/apache/incubator-streampark/pull/2288#discussion_r1095397788
##########
streampark-console/streampark-console-service/src/main/assembly/bin/streampark.sh:
##########
@@ -68,6 +68,20 @@ else
RESET=""
fi
+JAVA_OPTS="""
+ $vmOption
Review Comment:
Why do you move the position of `JAVA_OPTS`? , this will be `vmOption` variable is empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] zhangxiangyang commented on pull request #2288: [Optimize] streampark.sh starts adding debug mode
Posted by "zhangxiangyang (via GitHub)" <gi...@apache.org>.
zhangxiangyang commented on PR #2288:
URL: https://github.com/apache/incubator-streampark/pull/2288#issuecomment-1414745440
hi wolfboys:
I submitted an issue #2292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] zhangxiangyang commented on pull request #2288: [Feature][Issue-2292] streampark.sh starts adding debug mode
Posted by "zhangxiangyang (via GitHub)" <gi...@apache.org>.
zhangxiangyang commented on PR #2288:
URL: https://github.com/apache/incubator-streampark/pull/2288#issuecomment-1414763722
> hi zhangxiangyang:
>
> Thanks for your contribution. Usually, before submit a feature, there will be an "issue" first, describing the background and motivation clearly. I saw that the "debug" mode was added to this pr, also need to be added documentation. It will be smoother to have a good communication with the community
hi @wolfboys :
Thank you for your suggestion. I submitted a new issue #2292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] zhangxiangyang commented on a diff in pull request #2288: [Feature][Issue-2292] streampark.sh starts adding debug mode
Posted by "zhangxiangyang (via GitHub)" <gi...@apache.org>.
zhangxiangyang commented on code in PR #2288:
URL: https://github.com/apache/incubator-streampark/pull/2288#discussion_r1095519531
##########
streampark-console/streampark-console-service/src/main/assembly/bin/streampark.sh:
##########
@@ -68,6 +68,20 @@ else
RESET=""
fi
+JAVA_OPTS="""
+ $vmOption
Review Comment:
This problem has been fixed. Please review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org