You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rishabhbhardwaj <gi...@git.apache.org> on 2016/03/22 02:31:29 UTC
[GitHub] spark pull request: [SPARK-14036][MLlib]Removed mllib.tree.model.N...
GitHub user rishabhbhardwaj opened a pull request:
https://github.com/apache/spark/pull/11873
[SPARK-14036][MLlib]Removed mllib.tree.model.Node.build
## What changes were proposed in this pull request?
Removed build method from mllib.tree.model.Node.
## How was this patch tested?
The patch is tested with unit tests.
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rishabhbhardwaj/spark SPARK-14036
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11873.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11873
----
commit d152cb5ac855eeeac962a4b547f6f96522fd1223
Author: Rishabh Bhardwaj <rb...@gmail.com>
Date: 2015-10-19T06:42:56Z
[ SPARK-11180 ] [ SQL ] DataFrame.na.fill does not support Boolean Type
commit a53a20d756cfd26ca37acf9dbbd0b4e034f430d8
Author: Rishabh Bhardwaj <rb...@gmail.com>
Date: 2015-10-20T09:50:28Z
Merge remote-tracking branch 'upstream/master'
commit 870cbb384db84ffcc128114b38b495095e424ace
Author: Rishabh Bhardwaj <rb...@gmail.com>
Date: 2015-10-26T09:58:48Z
Merge remote-tracking branch 'upstream/master'
commit a21b0ed6d86811e5eedff0e4634da010062d225b
Author: Rishabh Bhardwaj <rb...@gmail.com>
Date: 2015-10-29T08:57:54Z
Merge remote-tracking branch 'upstream/master'
commit 079b1de9d6ddeeaf591a3707ecfffb1193d2a0f4
Author: Rishabh Bhardwaj <rb...@gmail.com>
Date: 2015-11-02T05:49:16Z
Merge remote-tracking branch 'upstream/master'
commit adb81bbfa5c872c0a63f912d091db89ef46628ee
Author: Rishabh Bhardwaj <ad...@admins-macbook-pro.local>
Date: 2015-11-28T11:31:24Z
Merge remote-tracking branch 'upstream/master'
commit cefd76a1a9600f932acffef3c017b7328d00e84b
Author: Rishabh Bhardwaj <rb...@gmail.com>
Date: 2015-12-03T13:53:56Z
Merge remote-tracking branch 'upstream/master'
commit 965386cfbeaf10a2e23062be4ced7dc866c60652
Author: Rishabh Bhardwaj <rb...@gmail.com>
Date: 2015-12-18T05:59:35Z
Merge remote-tracking branch 'upstream/master'
commit 1d9ad79ecc9f09506e78063a69ee5c0462cb53e9
Author: Rishabh Bhardwaj <rb...@gmail.com>
Date: 2016-01-04T05:11:49Z
Merge remote-tracking branch 'upstream/master'
commit 90b863d347189d4a59852d4235db4005d623f84d
Author: Rishabh Bhardwaj <rb...@gmail.com>
Date: 2016-01-22T06:40:59Z
Merge remote-tracking branch 'upstream/master'
commit 60015daf9589e3d1f1abfc948043017b44f4d53f
Author: Rishabh Bhardwaj <rb...@gmail.com>
Date: 2016-01-25T08:21:24Z
Merge remote-tracking branch 'upstream/master'
commit 3d8975b48cb6251d9ebb757f0681cbaa91b6fc20
Author: Rishabh Bhardwaj <rb...@gmail.com>
Date: 2016-02-09T05:39:39Z
Merge remote-tracking branch 'upstream/master'
commit 7e2c37d1674a12f8a50acbec7ea91f621044cdb0
Author: Rishabh Bhardwaj <rb...@gmail.com>
Date: 2016-03-10T18:41:58Z
Merge remote-tracking branch 'upstream/master'
commit e6d4e4f30d65c875306e3ceb0b92b614a0fa6077
Author: Rishabh Bhardwaj <rb...@gmail.com>
Date: 2016-03-11T05:30:08Z
Merge remote-tracking branch 'upstream/master'
commit 810a56b4b53fb897ebe48f4ee8ae8aba08f460e0
Author: Rishabh Bhardwaj <ad...@rishabh.local>
Date: 2016-03-16T06:59:16Z
Merge remote-tracking branch 'upstream/master'
commit 77f6aff11643f2197aff81b5c7920fe25cdf9c51
Author: Rishabh Bhardwaj <ad...@rishabh.local>
Date: 2016-03-21T17:25:50Z
Merge remote-tracking branch 'upstream/master'
commit 0d4365a53f4c42849ebf30cab4b3a9868fe93138
Author: Rishabh Bhardwaj <ad...@rishabh.local>
Date: 2016-03-22T01:27:13Z
Removed build method
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14036][MLlib]Removed mllib.tree.model.N...
Posted by rishabhbhardwaj <gi...@git.apache.org>.
Github user rishabhbhardwaj closed the pull request at:
https://github.com/apache/spark/pull/11873
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14036][MLlib]Removed mllib.tree.model.N...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11873#issuecomment-199641654
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53744/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14036][MLlib]Removed mllib.tree.model.N...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11873#issuecomment-199641444
**[Test build #53744 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53744/consoleFull)** for PR 11873 at commit [`0d4365a`](https://github.com/apache/spark/commit/0d4365a53f4c42849ebf30cab4b3a9868fe93138).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14036][MLlib]Removed mllib.tree.model.N...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11873#issuecomment-199634136
**[Test build #53744 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53744/consoleFull)** for PR 11873 at commit [`0d4365a`](https://github.com/apache/spark/commit/0d4365a53f4c42849ebf30cab4b3a9868fe93138).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14036][MLlib]Removed mllib.tree.model.N...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11873#issuecomment-199633533
LGTM pending Jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14036][MLlib]Removed mllib.tree.model.N...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11873#issuecomment-199641653
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14036][MLlib]Removed mllib.tree.model.N...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11873#issuecomment-199633500
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14036][MLlib]Removed mllib.tree.model.N...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11873#issuecomment-200495170
@rishabhbhardwaj I'm sorry, but it looks like this being done under https://github.com/apache/spark/pull/11910 now. To avoid conflicts, would you mind closing this PR? Thank you though!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14036][MLlib]Removed mllib.tree.model.N...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11873#issuecomment-199573944
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org