You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2011/10/30 00:01:11 UTC

svn commit: r1195055 - in /hbase/branches/0.92: CHANGES.txt src/main/java/org/apache/hadoop/hbase/util/Threads.java

Author: stack
Date: Sat Oct 29 22:01:10 2011
New Revision: 1195055

URL: http://svn.apache.org/viewvc?rev=1195055&view=rev
Log:
HBASE-4613 hbase.util.Threads#threadDumpingIsAlive sleeps 1 second, slowing down the shutdown by 0.5s

Modified:
    hbase/branches/0.92/CHANGES.txt
    hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Threads.java

Modified: hbase/branches/0.92/CHANGES.txt
URL: http://svn.apache.org/viewvc/hbase/branches/0.92/CHANGES.txt?rev=1195055&r1=1195054&r2=1195055&view=diff
==============================================================================
--- hbase/branches/0.92/CHANGES.txt (original)
+++ hbase/branches/0.92/CHANGES.txt Sat Oct 29 22:01:10 2011
@@ -394,6 +394,8 @@ Release 0.92.0 - Unreleased
    HBASE-4701  TestMasterObserver fails up on jenkins
    HBASE-4700  TestSplitTransactionOnCluster fails on occasion when it tries
                to move a region
+   HBASE-4613  hbase.util.Threads#threadDumpingIsAlive sleeps 1 second,
+               slowing down the shutdown by 0.5s
 
   TESTS
    HBASE-4492  TestRollingRestart fails intermittently

Modified: hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Threads.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Threads.java?rev=1195055&r1=1195054&r2=1195055&view=diff
==============================================================================
--- hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Threads.java (original)
+++ hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Threads.java Sat Oct 29 22:01:10 2011
@@ -106,11 +106,10 @@ public class Threads {
     if (t == null) {
       return;
     }
-    long startTime = System.currentTimeMillis();
+
     while (t.isAlive()) {
-      Thread.sleep(1000);
-      if (System.currentTimeMillis() - startTime > 60000) {
-        startTime = System.currentTimeMillis();
+      t.join(60 * 1000);
+      if (t.isAlive()) {
         ReflectionUtils.printThreadInfo(new PrintWriter(System.out),
             "Automatic Stack Trace every 60 seconds waiting on " +
             t.getName());