You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/20 01:08:46 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
HyukjinKwon opened a new pull request #30436:
URL: https://github.com/apache/spark/pull/30436
### What changes were proposed in this pull request?
I believe it's self-descriptive.
### Why are the changes needed?
To document supported features.
### Does this PR introduce _any_ user-facing change?
Yes, the docs are updated. It's master only.
### How was this patch tested?
Manually built the docs via `cd python/docs` and `make clean html`:

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730833449
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730835276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #30436:
URL: https://github.com/apache/spark/pull/30436#discussion_r527336121
##########
File path: python/docs/source/getting_started/install.rst
##########
@@ -68,8 +68,8 @@ It is recommended to use ``-v`` option in ``pip`` to track the installation and
HADOOP_VERSION=2.7 pip install pyspark -v
-Supported versions of Hadoop are ``HADOOP_VERSION=2.7`` and ``HADOOP_VERSION=3.2`` (default).
-Note that this installation of PySpark with a different version of Hadoop is experimental. It can change or be removed between minor releases.
+Supported values in ``HADOOP_VERSION`` are ``without``, ``2.7`` and ``3.2`` (default).
Review comment:
I might want to know what `without` means, like it's equivalent to `user-provided` one or something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730813239
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35986/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #30436:
URL: https://github.com/apache/spark/pull/30436#discussion_r527364178
##########
File path: python/docs/source/getting_started/install.rst
##########
@@ -68,8 +68,13 @@ It is recommended to use ``-v`` option in ``pip`` to track the installation and
HADOOP_VERSION=2.7 pip install pyspark -v
-Supported versions of Hadoop are ``HADOOP_VERSION=2.7`` and ``HADOOP_VERSION=3.2`` (default).
-Note that this installation of PySpark with a different version of Hadoop is experimental. It can change or be removed between minor releases.
+Supported values in ``HADOOP_VERSION`` are:
+
+- ``without``: Spark pre-built with user-provided Apache Hadoop
+- ``2.7``: Spark pre-built for Apache Hadoop 2.7
+- ``3.2``: Spark pre-built for Apache Hadoop 3.2 and later (default)
Review comment:
Awesome!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730758854
cc @ueshin can you take a quick look please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730806103
**[Test build #131389 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131389/testReport)** for PR 30436 at commit [`4826a68`](https://github.com/apache/spark/commit/4826a68e73449cbeb4460121ee3496dcf68b2757).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30436:
URL: https://github.com/apache/spark/pull/30436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730806372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730806427
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35986/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730792084
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730835270
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35993/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730754343
**[Test build #131383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131383/testReport)** for PR 30436 at commit [`333fdfa`](https://github.com/apache/spark/commit/333fdfa7fd910c72d11b1c28fa41f582d1161b1b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730797499
**[Test build #131389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131389/testReport)** for PR 30436 at commit [`4826a68`](https://github.com/apache/spark/commit/4826a68e73449cbeb4460121ee3496dcf68b2757).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730797499
**[Test build #131389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131389/testReport)** for PR 30436 at commit [`4826a68`](https://github.com/apache/spark/commit/4826a68e73449cbeb4460121ee3496dcf68b2757).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730835276
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730835278
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35993/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730827111
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35993/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730813257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730791801
**[Test build #131383 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131383/testReport)** for PR 30436 at commit [`333fdfa`](https://github.com/apache/spark/commit/333fdfa7fd910c72d11b1c28fa41f582d1161b1b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730813257
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730754343
**[Test build #131383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131383/testReport)** for PR 30436 at commit [`333fdfa`](https://github.com/apache/spark/commit/333fdfa7fd910c72d11b1c28fa41f582d1161b1b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730792084
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30436:
URL: https://github.com/apache/spark/pull/30436#discussion_r527343021
##########
File path: python/docs/source/getting_started/install.rst
##########
@@ -68,8 +68,8 @@ It is recommended to use ``-v`` option in ``pip`` to track the installation and
HADOOP_VERSION=2.7 pip install pyspark -v
-Supported versions of Hadoop are ``HADOOP_VERSION=2.7`` and ``HADOOP_VERSION=3.2`` (default).
-Note that this installation of PySpark with a different version of Hadoop is experimental. It can change or be removed between minor releases.
+Supported values in ``HADOOP_VERSION`` are ``without``, ``2.7`` and ``3.2`` (default).
Review comment:
Sure, let me update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730806372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30436: [MINOR][DOCS] Document 'without' value for HADOOP_VERSION in pip installation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30436:
URL: https://github.com/apache/spark/pull/30436#issuecomment-730813265
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35986/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org