You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Suresh Srinivas (Created) (JIRA)" <ji...@apache.org> on 2011/12/08 07:21:40 UTC
[jira] [Created] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
------------------------------------------------------------------------------------------
Key: HADOOP-7897
URL: https://issues.apache.org/jira/browse/HADOOP-7897
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 0.24.0
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
Fix For: 0.24.0
In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7897:
-------------------------------------------
Component/s: ipc
Fix Version/s: 0.23.3
I have merged this to 0.23.
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7897.txt, HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Sanjay Radia (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165066#comment-13165066 ]
Sanjay Radia commented on HADOOP-7897:
--------------------------------------
{code}
* <li>Exceptions encountered on the client side in this method are
* thrown as is.
{code}
Change to
{code}
* <li>Exceptions encountered on the client side in this method are
* wrapped in ServiceException as is.
{code}
+1
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165408#comment-13165408 ]
Hudson commented on HADOOP-7897:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1404 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1404/])
HADOOP-7897. ProtobufRpcEngine client side exception mechanism is not consistent with WritableRpcEngine. Contributed by Suresh Srinivas.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212004
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7897.txt, HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166269#comment-13166269 ]
Hudson commented on HADOOP-7897:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #889 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/889/])
HADOOP-7897. ProtobufRpcEngine client side exception mechanism is not consistent with WritableRpcEngine. Contributed by Suresh Srinivas.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212004
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7897.txt, HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166231#comment-13166231 ]
Hudson commented on HADOOP-7897:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #922 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/922/])
HADOOP-7897. ProtobufRpcEngine client side exception mechanism is not consistent with WritableRpcEngine. Contributed by Suresh Srinivas.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212004
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7897.txt, HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165360#comment-13165360 ]
Hudson commented on HADOOP-7897:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1454 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1454/])
HADOOP-7897. ProtobufRpcEngine client side exception mechanism is not consistent with WritableRpcEngine. Contributed by Suresh Srinivas.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212004
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7897.txt, HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7897:
------------------------------------
Attachment: HADOOP-7897.txt
Patch updated to incorporate comments.
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7897.txt, HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165086#comment-13165086 ]
Hadoop QA commented on HADOOP-7897:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506585/HADOOP-7897.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 9 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/448//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/448//console
This message is automatically generated.
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7897.txt, HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165346#comment-13165346 ]
Suresh Srinivas commented on HADOOP-7897:
-----------------------------------------
javadoc warnings are unrelated to this patch. I am not sure why javadoc warnings unnecessarily flags this as warnings for the patch!
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7897.txt, HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165363#comment-13165363 ]
Hudson commented on HADOOP-7897:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1380 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1380/])
HADOOP-7897. ProtobufRpcEngine client side exception mechanism is not consistent with WritableRpcEngine. Contributed by Suresh Srinivas.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212004
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7897.txt, HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7897:
------------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I committed the patch.
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7897.txt, HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7897:
------------------------------------
Status: Patch Available (was: Open)
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7897:
------------------------------------
Attachment: HADOOP-7897.txt
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7897) ProtobufRPCEngine client side
exception mechanism is not consistent with WritableRpcEngine
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165034#comment-13165034 ]
Hadoop QA commented on HADOOP-7897:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506576/HADOOP-7897.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 9 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/447//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/447//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/447//console
This message is automatically generated.
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-7897
> URL: https://issues.apache.org/jira/browse/HADOOP-7897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira