You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/09/13 22:23:02 UTC
[GitHub] [helix] micahstubbs opened a new pull request, #2211: 2210/partition list expand bug
micahstubbs opened a new pull request, #2211:
URL: https://github.com/apache/helix/pull/2211
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
#2210
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This PR [fixes a bug](https://github.com/swimlane/ngx-datatable/issues/1710) introduced by a breaking change in the ngx-datatable library sometime in the past.
It fixes the bug for the Partition List component, as well as all other affected components, namely:
- Job List
- Resource List
- Workflow List
### Tests
- [x] The following tests are written for this issue:
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
### Code Quality
- [x] My diff has been formatted using [Prettier](https://prettier.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2211: 2210/partition list expand bug
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2211:
URL: https://github.com/apache/helix/pull/2211#issuecomment-1246051944
This PR is ready to be merged, approved by @somecodemonkey
Final commit message:
## Fix partition-list row expand bug (#2210)
Update helix-front for a breaking change
introduced by dependency ngx-datatable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 merged pull request #2211: 2210/partition list expand bug
Posted by GitBox <gi...@apache.org>.
NealSun96 merged PR #2211:
URL: https://github.com/apache/helix/pull/2211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2211: 2210/partition list expand bug
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2211:
URL: https://github.com/apache/helix/pull/2211#issuecomment-1246086207
The CI Failure appears to be because of this ZooKeeper issue which is unrelated to these frontend changes:
```
77392 [TestNGInvoker-testGetChildrenOnLargeNumChildren()] ERROR org.apache.helix.zookeeper.zkclient.ZkClient [] - Failed to get children for path /testGetChildrenOnLargeNumChildren because of connection loss. Number of children 110000 exceeds limit 100000, aborting retry.
```
https://github.com/apache/helix/actions/runs/3048770554/jobs/4914181617#step:5:36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org