[GitHub] [lucene-solr] HoustonPutman opened a new pull request #887: SOLR-13773: Prometheus Exporter GC and Heap options

[GitBox <gi...@apache.org>]

HoustonPutman opened a new pull request #887: SOLR-13773: Prometheus Exporter GC and Heap options
URL: https://github.com/apache/lucene-solr/pull/887
 
 
   # Description
   
   The startup options for the Prometheus Exporter are pretty sparse compared to what the Solr start script offers.
   
   # Solution
   
   I've added some options that mirror what Solr offers, such as:
   - SOLR_HEAP
   - SOLR_JAVA_MEM
   - GC_TUNE
   
   Having just the memory settings available would let us start the prometheus exporter with more than 500 Mb of heap, which right now isn't possible as the max heap is hard coded here.
   
   # Tests
   
   I have started the metrics-exporter locally with this script, although I do not have access to a windows host to test the `solr-exporter.cmd` script. That code came from `solr.cmd` so I would imagine that it works, however I would appreciate if someone on windows could make sure that it works as expected.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request title.
   - [ ] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - [ ] I have developed this patch against the `master` branch.
   - [ ] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org