You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rdblue (via GitHub)" <gi...@apache.org> on 2026/04/24 18:34:59 UTC
[PR] Flink 2.1: Update LICENSE for 1.11. [iceberg]
rdblue opened a new pull request, #16102:
URL: https://github.com/apache/iceberg/pull/16102
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink 2.1: Update LICENSE for 1.11. [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on PR #16102:
URL: https://github.com/apache/iceberg/pull/16102#issuecomment-4331100334
Don't merge this until #16126 is in or else it will probably have a commit conflict. I'll rebase this to avoid issues with the other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink 2.1: Update LICENSE for 1.11. [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on code in PR #16102:
URL: https://github.com/apache/iceberg/pull/16102#discussion_r3139947499
##########
flink/v2.1/flink-runtime/LICENSE:
##########
@@ -258,14 +258,6 @@ License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2
--------------------------------------------------------------------------------
-This product bundles Apache Hive.
Review Comment:
Hive was originally bundled via ORC. [This change](https://github.com/apache/iceberg/commit/fb2c8ac3faf#diff-a41f76c79c2b739f4a1c7b21e2a68096118ea903c64b07710bd1bff717b5bfa2L254) removed that context, as well as that this was just the storage API.
When I looked at the contents of the Jar, there is only a META-INF directory that contains a properties file and a maven file. I don't think that any code is actually bundled, so this can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink 2.1: Update LICENSE for 1.11. [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on code in PR #16102:
URL: https://github.com/apache/iceberg/pull/16102#discussion_r3150761022
##########
flink/v2.1/flink-runtime/LICENSE:
##########
@@ -258,14 +258,6 @@ License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2
--------------------------------------------------------------------------------
-This product bundles Apache Hive.
Review Comment:
@amogh-jahagirdar, I fixed this. The diff is not easy to read, but Hive (storage API) and protobuf are now listed with notes that they were bundled by ORC.
We will need to simiarly update all runtimes that include ORC. I'll go make the same changes in #16104.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink 2.1: Update LICENSE for 1.11. [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on code in PR #16102:
URL: https://github.com/apache/iceberg/pull/16102#discussion_r3150683370
##########
flink/v2.1/flink-runtime/LICENSE:
##########
@@ -258,14 +258,6 @@ License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2
--------------------------------------------------------------------------------
-This product bundles Apache Hive.
Review Comment:
It looks like this is correct: ORC shades the classes into the ORC namespace and strips out the org.apache.hive part. It also includes Protobuf, which was caught by @manuzhang on #16104.
I'll add Protobuf and Hive Storage back to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink 2.1: Update LICENSE for 1.11. [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #16102:
URL: https://github.com/apache/iceberg/pull/16102#discussion_r3144040396
##########
flink/v2.1/flink-runtime/LICENSE:
##########
@@ -258,14 +258,6 @@ License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2
--------------------------------------------------------------------------------
-This product bundles Apache Hive.
Review Comment:
I'm not sure about this, when I look at the JAR I see actual classes being bundled (via ORC) as you mentioned. So I think at least the compiled classes are still being bundled, more than just the META-INF? Does that change if we'd include it here or not (just looks like the storage API as far as I can tell)?
```
org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimal$1.class
org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimal.class
org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimalV1.class
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink 2.1: Update LICENSE for 1.11. [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar merged PR #16102:
URL: https://github.com/apache/iceberg/pull/16102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink 2.1: Update LICENSE for 1.11. [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #16102:
URL: https://github.com/apache/iceberg/pull/16102#discussion_r3144040396
##########
flink/v2.1/flink-runtime/LICENSE:
##########
@@ -258,14 +258,6 @@ License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2
--------------------------------------------------------------------------------
-This product bundles Apache Hive.
Review Comment:
I'm not sure about this, when I look at the JAR I see actual classes being bundled (via ORC) as you mentioned. So I think at least the compiled classes are still being bundled, more than just the META-INF?
```
...
org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimal$1.class
org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimal.class
org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimalV1.class
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink 2.1: Update LICENSE for 1.11. [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on code in PR #16102:
URL: https://github.com/apache/iceberg/pull/16102#discussion_r3150610208
##########
flink/v2.1/flink-runtime/LICENSE:
##########
@@ -258,14 +258,6 @@ License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2
--------------------------------------------------------------------------------
-This product bundles Apache Hive.
Review Comment:
I missed these because they are in the org.apache.orc package. Are they actually Hive classes that come from hive-storage? I'll look into it a bit more. If so, then we will need to bring back the Hive entry and the additional context that was dropped in https://github.com/apache/iceberg/commit/fb2c8ac3faf342ec859075e5822e8477d1d26170.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink 2.1: Update LICENSE for 1.11. [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #16102:
URL: https://github.com/apache/iceberg/pull/16102#discussion_r3144040396
##########
flink/v2.1/flink-runtime/LICENSE:
##########
@@ -258,14 +258,6 @@ License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2
--------------------------------------------------------------------------------
-This product bundles Apache Hive.
Review Comment:
I'm not sure about this, when I look at the JAR I see actual classes being bundled (via ORC) as you mentioned. So I think at least the compiled classes are still being bundled, more than just the META-INF? Does that change if we'd include it here or not?
```
org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimal$1.class
org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimal.class
org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimalV1.class
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink 2.1: Update LICENSE for 1.11. [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #16102:
URL: https://github.com/apache/iceberg/pull/16102#discussion_r3144040396
##########
flink/v2.1/flink-runtime/LICENSE:
##########
@@ -258,14 +258,6 @@ License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2
--------------------------------------------------------------------------------
-This product bundles Apache Hive.
Review Comment:
I'm not sure about this, when I look at the JAR I see actual classes being bundled (via ORC) as you mentioned. So I think at least the compiled classes are still being bundled, more than just the META-INF?
```
org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimal$1.class
org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimal.class
org/apache/iceberg/shaded/org/apache/orc/storage/common/type/HiveDecimalV1.class
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org