You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Massimo Lusetti <ml...@gmail.com> on 2013/08/05 11:42:07 UTC
@PageActivationContext regression in 5.4-alpha-14 !?
Hi devs,
it's me or with 5.4-alpha-14 is it possible to use PageActivationContext
annotation within a page with a onActivate method?
If this is the case is clearly a regression.
Would anyone confirm please?
--
Massimo Lusetti
Re: @PageActivationContext regression in 5.4-alpha-14 !?
Posted by Howard Lewis Ship <hl...@gmail.com>.
Yes; I'd update the Javadoc, since what 5.3/5.4 does is actually better.
On Mon, Aug 5, 2013 at 8:33 AM, Massimo Lusetti <ml...@gmail.com> wrote:
> On Mon, Aug 5, 2013 at 5:27 PM, Howard Lewis Ship <hl...@gmail.com>
> wrote:
>
> I'm unaware of a problem; this is certainly a case of unexpected
> > consequences. Is it a change in behavior?
> >
> > Please explain the mismatch,
> >
> > thanks!
> >
> >
> Well the javadoc of PageActivationContext annotation states:
> "You should not use this annotation within a class that already has an
> onActivate() or onPassivate() method; doing so will result in a runtime
> exception."
>
> But the reality is that the annotation worker simply check for double
> presence of the annotation on the same page but not for the presence of a
> activation handler method, so on 5.4 and 5.3.x you can have
> @PageActivationContext with onActivate method on pages while the javadoc
> says the opposite.
>
> Am I enough clear?
> --
> Massimo Lusetti
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
Re: @PageActivationContext regression in 5.4-alpha-14 !?
Posted by Massimo Lusetti <ml...@gmail.com>.
On Mon, Aug 5, 2013 at 5:27 PM, Howard Lewis Ship <hl...@gmail.com> wrote:
I'm unaware of a problem; this is certainly a case of unexpected
> consequences. Is it a change in behavior?
>
> Please explain the mismatch,
>
> thanks!
>
>
Well the javadoc of PageActivationContext annotation states:
"You should not use this annotation within a class that already has an
onActivate() or onPassivate() method; doing so will result in a runtime
exception."
But the reality is that the annotation worker simply check for double
presence of the annotation on the same page but not for the presence of a
activation handler method, so on 5.4 and 5.3.x you can have
@PageActivationContext with onActivate method on pages while the javadoc
says the opposite.
Am I enough clear?
--
Massimo Lusetti
Re: @PageActivationContext regression in 5.4-alpha-14 !?
Posted by Howard Lewis Ship <hl...@gmail.com>.
I'm unaware of a problem; this is certainly a case of unexpected
consequences. Is it a change in behavior?
Please explain the mismatch,
thanks!
On Mon, Aug 5, 2013 at 6:23 AM, Massimo Lusetti <ml...@gmail.com> wrote:
> Now the question is: Change the javadoc to reflect actual behavior or
> change the implementation to reflect behavior describe in javadoc ?
>
>
> On Mon, Aug 5, 2013 at 12:32 PM, Massimo Lusetti <ml...@gmail.com>
> wrote:
>
> > Further research seems to show that is the Javadoc which is incorrect...
> >
> >
> > On Mon, Aug 5, 2013 at 11:42 AM, Massimo Lusetti <mlusetti@gmail.com
> >wrote:
> >
> >> Hi devs,
> >> it's me or with 5.4-alpha-14 is it possible to use
> >> PageActivationContext annotation within a page with a onActivate method?
> >>
> >> If this is the case is clearly a regression.
> >>
> >> Would anyone confirm please?
> >> --
> >> Massimo Lusetti
> >>
> >
> >
> >
> > --
> > Massimo Lusetti
> >
>
>
>
> --
> Massimo Lusetti
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
Re: @PageActivationContext regression in 5.4-alpha-14 !?
Posted by Massimo Lusetti <ml...@gmail.com>.
Now the question is: Change the javadoc to reflect actual behavior or
change the implementation to reflect behavior describe in javadoc ?
On Mon, Aug 5, 2013 at 12:32 PM, Massimo Lusetti <ml...@gmail.com> wrote:
> Further research seems to show that is the Javadoc which is incorrect...
>
>
> On Mon, Aug 5, 2013 at 11:42 AM, Massimo Lusetti <ml...@gmail.com>wrote:
>
>> Hi devs,
>> it's me or with 5.4-alpha-14 is it possible to use
>> PageActivationContext annotation within a page with a onActivate method?
>>
>> If this is the case is clearly a regression.
>>
>> Would anyone confirm please?
>> --
>> Massimo Lusetti
>>
>
>
>
> --
> Massimo Lusetti
>
--
Massimo Lusetti
Re: @PageActivationContext regression in 5.4-alpha-14 !?
Posted by Massimo Lusetti <ml...@gmail.com>.
Further research seems to show that is the Javadoc which is incorrect...
On Mon, Aug 5, 2013 at 11:42 AM, Massimo Lusetti <ml...@gmail.com> wrote:
> Hi devs,
> it's me or with 5.4-alpha-14 is it possible to use PageActivationContext
> annotation within a page with a onActivate method?
>
> If this is the case is clearly a regression.
>
> Would anyone confirm please?
> --
> Massimo Lusetti
>
--
Massimo Lusetti