You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2018/07/06 07:28:35 UTC

[GitHub] spark pull request #21724: [SPARK-24749] Use sameType to compare Array's ele...

GitHub user viirya opened a pull request:

    https://github.com/apache/spark/pull/21724

    [SPARK-24749] Use sameType to compare Array's element type in ArrayContains

    ## What changes were proposed in this pull request?
    
    We should use `DataType.sameType` to compare element type in `ArrayContains`, otherwise nullability affects comparison result.
    
    ## How was this patch tested?
    
    Added test.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/viirya/spark-1 SPARK-24749

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21724
    
----
commit 2c16b4e0b89985886f4f588f39c71249f92f3aa9
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-07-06T07:24:24Z

    Use sameType to compare Array's element type.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    retest this please.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #21724: [SPARK-24749][SQL] Use sameType to compare Array'...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/21724


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92700/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    @HyukjinKwon I've noticed that too and already sent an email to CRAN sysadmin to ask for fixing it. I think it is fixed now.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    **[Test build #92673 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92673/testReport)** for PR 21724 at commit [`2c16b4e`](https://github.com/apache/spark/commit/2c16b4e0b89985886f4f588f39c71249f92f3aa9).
     * This patch **fails SparkR unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/741/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    Merged to master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/722/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    **[Test build #92673 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92673/testReport)** for PR 21724 at commit [`2c16b4e`](https://github.com/apache/spark/commit/2c16b4e0b89985886f4f588f39c71249f92f3aa9).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92673/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    **[Test build #92700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92700/testReport)** for PR 21724 at commit [`2c16b4e`](https://github.com/apache/spark/commit/2c16b4e0b89985886f4f588f39c71249f92f3aa9).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    **[Test build #92700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92700/testReport)** for PR 21724 at commit [`2c16b4e`](https://github.com/apache/spark/commit/2c16b4e0b89985886f4f588f39c71249f92f3aa9).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21724: [SPARK-24749][SQL] Use sameType to compare Array's eleme...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/21724
  
    Hm, BTW @viirya,
    
    ```
    * checking CRAN incoming feasibility ...Error in .check_package_CRAN_incoming(pkgdir) : 
      dims [product 24] do not match the length of object [0]
    Execution halted
    ```
    
    This seems the same issue again. I reopened https://issues.apache.org/jira/browse/SPARK-24152.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org